-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nx support #41
Comments
Hi @edbzn, Currently, only an Angular CLI workspace is supported. We would like to support an Nx workspace since we're using Nx ourselves in our monorepos. For example, it's blocking me from releasing Spectacular 1.0. At the very least, we need:
Ideally, we also need to solve one of or both:
Because currently we add all dependencies listed in our combinations based only on the target <major>.<minor> Angular version. We're not currently working actively on this feature. We'd appreciate all the help we can get. |
I start working on the dependency combination for Nx. In terms of implementation, I think the best would be to autodetect Nx by checking |
Hi @edbzn, I'm very thankful that you have started working on this task. There is a branch in the repo with some initial efforts on this issue, but it is very outdated; however, it could provide maybe some help. Nonetheless, I'd be thrilled to have an architecture meeting with you to make together all these kinds of initial design decisions if you would like to. For now, yes, autodetection is a good strategy, and I believe it was our way to go. However, we need to be careful since Nx might be moving towards eliminating all the root configuration files replacing them with per projects configurations files. I'll look for my notes about this task and let you know. |
The WIP branch is |
nx.json might go away in the future according to Nrwl. But it's good for now. |
What is the motivation/use case for changing the behavior?
Hi there, I want to use this action for maintaining Angular libraries within an Nx workspace.
Does it already support Nx? I would like to know how to achieve this.
Describe the solution you'd like
Support + documentation for an Nx workspace.
Thanks in advance.
The text was updated successfully, but these errors were encountered: