Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

njk head has hard coded Links to your site for webmentions #330

Open
inetbiz opened this issue Oct 27, 2021 · 1 comment
Open

njk head has hard coded Links to your site for webmentions #330

inetbiz opened this issue Oct 27, 2021 · 1 comment
Labels
feature: documentation 📑 Improvements or additions to documentation feature: webmention 💭 priority: high 🟠 type: enhancement 🧗‍♂️ New feature or request

Comments

@inetbiz
Copy link

inetbiz commented Oct 27, 2021 •
edited
Loading

Template Head - Link Source Webmention

The nunchucks <head> for WebMentions should not be hard coded.

<link rel="webmention" href="https://webmention.io/pack11ty.dev/webmention" />
<link rel="pingback" href="https://webmention.io/pack11ty.dev/xmlrpc" />

I think that should be populated from $(domain)? I don't know if that is a global or not to add to njk head?
@inetbiz inetbiz changed the title [Template Head - Link Source Webmention](https://github.com/nhoizey/pack11ty/blob/65bfbcb64f2c4779ebed2a27c7466002e1296e3b/src/_includes/head.njk#L50) njk head has hard coded Links to your site for webmentions Oct 27, 2021
@nhoizey
Copy link
Owner

nhoizey commented Oct 28, 2021

@inetbiz good catch indeed, thanks!

Unfortunately, the site domain is not enough, as people can setup Webmention support without webmention.io

I guess I should add two new settings in pack11ty.config.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: documentation 📑 Improvements or additions to documentation feature: webmention 💭 priority: high 🟠 type: enhancement 🧗‍♂️ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhoizey @inetbiz