Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop SSL Strategy/Story #415

Open
jolhoeft opened this issue Nov 19, 2017 · 5 comments
Open

Develop SSL Strategy/Story #415

jolhoeft opened this issue Nov 19, 2017 · 5 comments
Labels
T-feature

Comments

@jolhoeft
Copy link
Member

jolhoeft commented Nov 19, 2017 •
edited
Loading

We inadvertently disabled SSL support in the upgrade to hyper 0.10 (sadly, no one noticed). Hyper 0.11 does not have native SSL support.
jolhoeft added a commit to jolhoeft/nickel.rs that referenced this issue Nov 19, 2017
@jolhoeft
fix(examples): Fix examples triggering issue nickel-org#399
f829a84 
Fix the examples that were returning MiddlewareResults in the
middlware! macro. A couple could be changed to return a Responder, but
most needed to be reimplemented as seperate functions.

Updated the middleware! macro documentaion to note the limitations
from issues nickel-org#399 and nickel-org#389.

Disable ssl testing in travis, which was broken in commit
8d5a7d0. Issue nickel-org#415 to track
our SSL plan.
@jolhoeft jolhoeft mentioned this issue Nov 19, 2017
Merged
@jolhoeft jolhoeft mentioned this issue Nov 20, 2017
Closed
@eltomito
Copy link

Hi! Is there a way to use https in a Nickel server now? I just finished a web app that uses Nickel and was about to make it use https but no luck with the examples and yeah, hyper::net::Openssl is gone. Thank you!

@jolhoeft
Copy link
Member Author

My current approach is to use Apache for https. Apache redirects to a localhost only port where my nickel app is listening.

We definitely want https support in Nickel, but that will probably be added back after the migration to hyper-0.11.x is complete, and hyper's approach to https has settled down a bit.

jolhoeft added a commit to jolhoeft/nickel.rs that referenced this issue Nov 23, 2017
@jolhoeft
fix(examples): Fix examples triggering issue nickel-org#399
433a599 
Fix the examples that were returning MiddlewareResults in the
middlware! macro. A couple could be changed to return a Responder, but
most needed to be reimplemented as seperate functions.

Updated the middleware! macro documentaion to note the limitations
from issues nickel-org#399 and nickel-org#389.

Disable ssl testing in travis, which was broken in commit
8d5a7d0. Issue nickel-org#415 to track
our SSL plan.
@eltomito
Copy link

Okay, I ended up doing the same thing using nginx. Thank you!

@archae0pteryx
Copy link

archae0pteryx commented Dec 31, 2017 •
edited
Loading

A temp solution could be to use a free caching service like cloudflare and use them for the tls?

@eltomito
Copy link

Nah, thanks, nginx work fine :)

@jolhoeft jolhoeft mentioned this issue Jan 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jolhoeft @eltomito @archae0pteryx