Fix Unparenthesized a ? b : c ? d : e is deprecated. Use either (a ? b : c) ? d : e or a ? b : (c ? d : e) depreciation in Cuztom library

nicomollet · nicomollet · commit 579f48b6897f · 2022-08-12T16:04:02.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,5 @@
 * **Tweak** - Images: alignment on images (picture tag)
+* **Fix** - Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)` depreciation
 
 ### 0.8.8: May 30th, 2022
 * **Fix** - Update markdown-it and modernizr vulnerable versions
diff --git a/inc/library/cuztom/classes/fields/checkboxes.class.php b/inc/library/cuztom/classes/fields/checkboxes.class.php
@@ -23,7 +23,9 @@ function _output( $value )
 			{
 				foreach( $this->options as $slug => $name )
 				{
-					$output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $slug ) ) . ' ' . $this->output_css_class() . ' value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'checked="checked"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $slug, $this->default_value ) ? 'checked="checked"' : '' ) ) . ' /> ';
+					$output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $slug ) ) . ' ' . $this->output_css_class() . ' value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'checked="checked"' : '' ) : ( ( $value
+					                                                                                                                                                                                                                                                                                                          == '-1' )
+							? '' : ( in_array( $slug, $this->default_value ) ? 'checked="checked"' : '' ) ) ) . ' /> ';
 					$output .= '<label ' . $this->output_for_attribute( $this->id . $this->after_id . '_' . Cuztom::uglify( $slug ) ) . '>' . Cuztom::beautify( $name ) . '</label>';
 					$output .= '<br />';
 				}
diff --git a/inc/library/cuztom/classes/fields/multi_select.class.php b/inc/library/cuztom/classes/fields/multi_select.class.php
@@ -20,13 +20,16 @@ function _output( $value )
 	{
 		$output = '<select ' . $this->output_name() . ' ' . $this->output_id() . ' ' . $this->output_css_class() . ' multiple="true">';
 			if( isset( $this->args['show_option_none'] ) )
-				$output .= '<option value="0" ' . ( is_array( $value ) ? ( in_array( 0, $value ) ? 'selected="selected"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( 0, $this->default_value ) ? 'selected="selected"' : '' ) ) . '>' . $this->args['show_option_none'] . '</option>';
+				$output .= '<option value="0" ' . ( is_array( $value ) ? ( in_array( 0, $value ) ? 'selected="selected"' : '' ) : ( ( $value == '-1' )
+						? '' : ( in_array( 0, $this->default_value ) ? 'selected="selected"' : '' ) ) ) . '>' . $this->args['show_option_none'] . '</option>';
 
 			if( is_array( $this->options ) )
 			{
 				foreach( $this->options as $slug => $name )
 				{
-					$output .= '<option value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'selected="selected"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $slug, $this->default_value ) ? 'selected="selected"' : '' ) ) . '>' . Cuztom::beautify( $name ) . '</option>';
+					$output .= '<option value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'selected="selected"' : '' ) : ( ( $value
+					                                                                                                                                      == '-1' )
+							? '' : ( in_array( $slug, $this->default_value ) ? 'selected="selected"' : '' ) ) ) . '>' . Cuztom::beautify( $name ) . '</option>';
 				}
 			}
 		$output .= '</select>';
diff --git a/inc/library/cuztom/classes/fields/post_checkboxes.class.php b/inc/library/cuztom/classes/fields/post_checkboxes.class.php
@@ -32,7 +32,9 @@ function _output( $value )
 			{
 				foreach( $this->posts as $post )
 				{
-					$output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $post->post_title ) ) . ' ' . $this->output_css_class() . ' value="' . $post->ID . '" ' . ( is_array( $value ) ? ( in_array( $post->ID, $value ) ? 'checked="checked"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $post->ID, $this->default_value ) ? 'checked="checked"' : '' ) ) . ' /> ';
+					$output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $post->post_title ) ) . ' ' . $this->output_css_class() . ' value="' . $post->ID . '" ' . ( is_array( $value ) ? ( in_array( $post->ID, $value ) ? 'checked="checked"' : '' ) : ( ( $value
+					                                                                                                                                                                                                                                                                                                                              == '-1' )
+							? '' : ( in_array( $post->ID, $this->default_value ) ? 'checked="checked"' : '' ) ) ) . ' /> ';
 					$output .= '<label for="' . $this->id . $this->after_id . '_' . Cuztom::uglify( $post->post_title ) . '">' . $post->post_title . '</label>';
 					$output .= '<br />';
 				}
diff --git a/inc/library/cuztom/classes/fields/term_checkboxes.class.php b/inc/library/cuztom/classes/fields/term_checkboxes.class.php
@@ -34,7 +34,9 @@ function _output( $value )
 			{
 				foreach( $this->terms as $term )
 				{
-					$output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $term->name ) ) . ' ' . $this->output_css_class() . ' value="' . $term->term_id . '" ' . ( is_array( $value ) ? ( in_array( $term->term_id, $value ) ? 'checked="checked"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $term->term_id, $this->default_value ) ? 'checked="checked"' : '' ) ) . ' /> ';
+					$output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $term->name ) ) . ' ' . $this->output_css_class() . ' value="' . $term->term_id . '" ' . ( is_array( $value ) ? ( in_array( $term->term_id, $value ) ? 'checked="checked"' : '' ) : ( ( $value
+					                                                                                                                                                                                                                                                                                                                                  == '-1' )
+							? '' : ( in_array( $term->term_id, $this->default_value ) ? 'checked="checked"' : '' ) ) ) . ' /> ';
 					$output .= '<label for="' . $this->id . $this->after_id . '_' . Cuztom::uglify( $term->name ) . '">' . $term->name . '</label>';
 					$output .= '<br />';
 				}

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`* Tweak - Images: alignment on images (picture tag)`
	`2`	+* Fix - Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)` depreciation
`2`	`3`
`3`	`4`	`### 0.8.8: May 30th, 2022`
`4`	`5`	`* Fix - Update markdown-it and modernizr vulnerable versions`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,9 @@ function _output( $value )`
`23`	`23`	`{`
`24`	`24`	`foreach( $this->options as $slug => $name )`
`25`	`25`	`{`
`26`		`- $output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $slug ) ) . ' ' . $this->output_css_class() . ' value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'checked="checked"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $slug, $this->default_value ) ? 'checked="checked"' : '' ) ) . ' /> ';`
	`26`	`+ $output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $slug ) ) . ' ' . $this->output_css_class() . ' value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'checked="checked"' : '' ) : ( ( $value`
	`27`	`+ == '-1' )`
	`28`	`+ ? '' : ( in_array( $slug, $this->default_value ) ? 'checked="checked"' : '' ) ) ) . ' /> ';`
`27`	`29`	`$output .= '<label ' . $this->output_for_attribute( $this->id . $this->after_id . '_' . Cuztom::uglify( $slug ) ) . '>' . Cuztom::beautify( $name ) . '</label>';`
`28`	`30`	`$output .= '<br />';`
`29`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,13 +20,16 @@ function _output( $value )`
`20`	`20`	`{`
`21`	`21`	`$output = '<select ' . $this->output_name() . ' ' . $this->output_id() . ' ' . $this->output_css_class() . ' multiple="true">';`
`22`	`22`	`if( isset( $this->args['show_option_none'] ) )`
`23`		`- $output .= '<option value="0" ' . ( is_array( $value ) ? ( in_array( 0, $value ) ? 'selected="selected"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( 0, $this->default_value ) ? 'selected="selected"' : '' ) ) . '>' . $this->args['show_option_none'] . '</option>';`
	`23`	`+ $output .= '<option value="0" ' . ( is_array( $value ) ? ( in_array( 0, $value ) ? 'selected="selected"' : '' ) : ( ( $value == '-1' )`
	`24`	`+ ? '' : ( in_array( 0, $this->default_value ) ? 'selected="selected"' : '' ) ) ) . '>' . $this->args['show_option_none'] . '</option>';`
`24`	`25`
`25`	`26`	`if( is_array( $this->options ) )`
`26`	`27`	`{`
`27`	`28`	`foreach( $this->options as $slug => $name )`
`28`	`29`	`{`
`29`		`- $output .= '<option value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'selected="selected"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $slug, $this->default_value ) ? 'selected="selected"' : '' ) ) . '>' . Cuztom::beautify( $name ) . '</option>';`
	`30`	`+ $output .= '<option value="' . $slug . '" ' . ( is_array( $value ) ? ( in_array( $slug, $value ) ? 'selected="selected"' : '' ) : ( ( $value`
	`31`	`+ == '-1' )`
	`32`	`+ ? '' : ( in_array( $slug, $this->default_value ) ? 'selected="selected"' : '' ) ) ) . '>' . Cuztom::beautify( $name ) . '</option>';`
`30`	`33`	`}`
`31`	`34`	`}`
`32`	`35`	`$output .= '</select>';`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,9 @@ function _output( $value )`
`32`	`32`	`{`
`33`	`33`	`foreach( $this->posts as $post )`
`34`	`34`	`{`
`35`		`- $output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $post->post_title ) ) . ' ' . $this->output_css_class() . ' value="' . $post->ID . '" ' . ( is_array( $value ) ? ( in_array( $post->ID, $value ) ? 'checked="checked"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $post->ID, $this->default_value ) ? 'checked="checked"' : '' ) ) . ' /> ';`
	`35`	`+ $output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $post->post_title ) ) . ' ' . $this->output_css_class() . ' value="' . $post->ID . '" ' . ( is_array( $value ) ? ( in_array( $post->ID, $value ) ? 'checked="checked"' : '' ) : ( ( $value`
	`36`	`+ == '-1' )`
	`37`	`+ ? '' : ( in_array( $post->ID, $this->default_value ) ? 'checked="checked"' : '' ) ) ) . ' /> ';`
`36`	`38`	`$output .= '<label for="' . $this->id . $this->after_id . '_' . Cuztom::uglify( $post->post_title ) . '">' . $post->post_title . '</label>';`
`37`	`39`	`$output .= '<br />';`
`38`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,9 @@ function _output( $value )`
`34`	`34`	`{`
`35`	`35`	`foreach( $this->terms as $term )`
`36`	`36`	`{`
`37`		`- $output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $term->name ) ) . ' ' . $this->output_css_class() . ' value="' . $term->term_id . '" ' . ( is_array( $value ) ? ( in_array( $term->term_id, $value ) ? 'checked="checked"' : '' ) : ( ( $value == '-1' ) ? '' : in_array( $term->term_id, $this->default_value ) ? 'checked="checked"' : '' ) ) . ' /> ';`
	`37`	`+ $output .= '<input type="checkbox" ' . $this->output_name() . ' ' . $this->output_id( $this->id . $this->after_id . '_' . Cuztom::uglify( $term->name ) ) . ' ' . $this->output_css_class() . ' value="' . $term->term_id . '" ' . ( is_array( $value ) ? ( in_array( $term->term_id, $value ) ? 'checked="checked"' : '' ) : ( ( $value`
	`38`	`+ == '-1' )`
	`39`	`+ ? '' : ( in_array( $term->term_id, $this->default_value ) ? 'checked="checked"' : '' ) ) ) . ' /> ';`
`38`	`40`	`$output .= '<label for="' . $this->id . $this->after_id . '_' . Cuztom::uglify( $term->name ) . '">' . $term->name . '</label>';`
`39`	`41`	`$output .= '<br />';`
`40`	`42`	`}`