httpdinfo: fix resource leak

fhuberts · fhuberts · commit 808928830ed6 · 2012-10-22T18:09:01.000+02:00
Coverity: CID 739676 (#1 of 1): Resource leak (RESOURCE_LEAK) At (18): Handle variable "client_socket" going out of scope leaks the handle. Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
diff --git a/lib/httpinfo/src/olsrd_httpinfo.c b/lib/httpinfo/src/olsrd_httpinfo.c
@@ -537,8 +537,6 @@ parse_http_request(int fd, void *data __attribute__ ((unused)), unsigned int fla
       writetimer_entry = olsr_start_timer(100, 0, OLSR_TIMER_PERIODIC, &httpinfo_write_data, NULL, 0);
     }
   }
-  abuf_free(&body_abuf);
-  return;
 
 close_connection:
   abuf_free(&body_abuf);

Original file line number	Diff line number	Diff line change
`@@ -537,8 +537,6 @@ parse_http_request(int fd, void *data __attribute__ ((unused)), unsigned int fla`
`537`	`537`	`writetimer_entry = olsr_start_timer(100, 0, OLSR_TIMER_PERIODIC, &httpinfo_write_data, NULL, 0);`
`538`	`538`	`}`
`539`	`539`	`}`
`540`		`- abuf_free(&body_abuf);`
`541`		`- return;`
`542`	`540`
`543`	`541`	`close_connection:`
`544`	`542`	`abuf_free(&body_abuf);`