Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whna: improve efficiency by recycling packets #3

Open
cl4u2 opened this issue Jul 5, 2012 · 0 comments
Open

whna: improve efficiency by recycling packets #3

cl4u2 opened this issue Jul 5, 2012 · 0 comments
Labels
enhancement whna

Comments

@cl4u2
Copy link
Member

cl4u2 commented Jul 5, 2012

At the moment at each interval a new packet is allocated, processed and freed. Having instead packets created at init time and have updated only sequence numbers at each interval and deallocation on the plugin's destroy would be better.
zioproto pushed a commit that referenced this issue Nov 15, 2012
@HRogge
Use strscpy instead of strncpy.
886bfb5 
    Coverity:

    CID 739613 (#1 of 1): Buffer not null terminated (BUFFER_SIZE_WARNING)
    At (6): Calling strncpy with a maximum size argument of 16 bytes on destination array "t->if_name" of size 16 bytes might leave the destination string unterminated.

    CID 739614 (#1 of 3): Buffer not null terminated (BUFFER_SIZE_WARNING)
    At (4): Calling strncpy with a maximum size argument of 16 bytes on destination array "p4.name" of size 16 bytes might leave the destination string unterminated.

    CID 739614 (#2 of 3): Buffer not null terminated (BUFFER_SIZE_WARNING)
    At (4): Calling strncpy with a maximum size argument of 16 bytes on destination array "p6.name" of size 16 bytes might leave the destination string unterminated.

    CID 739614 (#3 of 3): Buffer not null terminated (BUFFER_SIZE_WARNING)
    At (5): Calling strncpy with a maximum size argument of 16 bytes on destination array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the destination string unterminated.

    Signed-off-by: Henning Rogge <[email protected]>
zioproto pushed a commit that referenced this issue Nov 15, 2012
@fhuberts
bmf: do not close an fd that is not open
57cdbf6 
CID 739656 (#1 of 4): Argument cannot be negative (NEGATIVE_RETURNS)
At (7): "encapsulatingSkfd" is passed to a parameter that cannot be
        negative.
CID 739656 (#2 of 4): Argument cannot be negative (NEGATIVE_RETURNS)
At (9): "encapsulatingSkfd" is passed to a parameter that cannot be
        negative.
CID 739656 (#3 of 4): Argument cannot be negative (NEGATIVE_RETURNS)
At (12): "capturingSkfd" is passed to a parameter that cannot be
         negative.
CID 739656 (#4 of 4): Argument cannot be negative (NEGATIVE_RETURNS)
At (11): "encapsulatingSkfd" is passed to a parameter that cannot be
         negative.

Signed-off-by: Ferry Huberts <[email protected]>
gabri94 pushed a commit to gabri94/olsrd that referenced this issue Apr 28, 2016
@fhuberts
conf: clean up interface names on config file read failure
7f7133b 
==12076==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 7 byte(s) in 1 object(s) allocated from:
    #0 0x499bba in __interceptor_malloc (/home/ferry/vcs/nbs/nbsolsrd/olsrd+0x499bba)
    ninuxorg#1 0x5784cd in get_string_token src/cfgparser/oscan.lex:92
    ninuxorg#2 0x578ef7 in yylex src/cfgparser/oscan.lex:185
    ninuxorg#3 0x5699c4 in yyparse src/cfgparser/oparse.c:1686
    ninuxorg#4 0x55e322 in olsrd_parse_cnf src/cfgparser/olsrd_conf.c:158
    ninuxorg#5 0x4edf56 in olsrmain_load_config src/main.c:281
    ninuxorg#6 0x4ee5e6 in main src/main.c:386
    #7 0x7fd24079757f in __libc_start_main (/lib64/libc.so.6+0x2057f)

SUMMARY: AddressSanitizer: 7 byte(s) leaked in 1 allocation(s).

Signed-off-by: Ferry Huberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement whna
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cl4u2