Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable map container #19

Open
MoonDragon-MD opened this issue Jan 14, 2025 · 6 comments
Open

Resizable map container #19

MoonDragon-MD opened this issue Jan 14, 2025 · 6 comments
Labels
enhancement New feature or request

Comments

@MoonDragon-MD
Copy link

MoonDragon-MD commented Jan 14, 2025

Hi thanks for your addon! I wanted to know if you can add a way to ingrad the map at will, I had intesion to create a JS script but I have problems with the map, then I found your project. If you want here is the code (if you have time I would like to know why it loads the map badly): rename .txt to js
OSMonGM.txt

@nobkd
Copy link
Owner

nobkd commented Jan 14, 2025

Hey, what do you mean with ingrad the map at will?

What exactly is the issue with the map with your script?

  • is the zoom level way off?

    include altitude by prepending your regex with !1d(...)
    use sth similar to this code piece to convert to zoom level and include in your L.map(..., { ..., zoom: convertedZoomValue }).
    this code snippet is off sometimes, but it's alright in most cases... just play around with it, to see if it fits

  • are the tiles jumbled?

    did you include the leaflet css style sheet?

  • something else?

Your regex seems fine, as it takes the first location this occurs.

@MoonDragon-MD
Copy link
Author

MoonDragon-MD commented Jan 14, 2025

Hey, what do you mean with ingrad the map at will?

Yes, sorry, I wrote in Italian, "enlarge the map at will" that is, create a moving border at the bottom right, if you try you see a square, with the mouse click and move to enlarge or shrink.

Thanks, I'll try to study better with the advice you gave me!

@nobkd
Copy link
Owner

nobkd commented Jan 15, 2025

Okay, great. Is this a feature request for this add-on, to add the resize functionality to the map iframe, or did you just want help with your script? Or maybe both?

@MoonDragon-MD
Copy link
Author

Okay, great. Is this a feature request for this add-on, to add the resize functionality to the map iframe, or did you just want help with your script? Or maybe both?

A feature request and since I had made the script, I also thought I'd ask you, I hope I wasn't being indiscreet, thanks for your time

@nobkd
Copy link
Owner

nobkd commented Jan 15, 2025

I'll probably take a look tomorrow. I can't promise anything though, cause I'm currently a bit preoccupied with other stuff.

I also might need to refractor some of my code, because I learned a lot in the past few months, and I'm sure, I can do at least some things much better now than back when I started this project. :)

@nobkd nobkd changed the title Info Resizable map container Jan 15, 2025
@MoonDragon-MD
Copy link
Author

Thank you very much, there is no hurry! You never stop learning, I wish you good work :)

@nobkd nobkd added the enhancement New feature or request label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants