Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current status of LTS group/ backporters #1012

Closed
marco-ippolito opened this issue May 30, 2024 · 2 comments · Fixed by #1037
Closed

Current status of LTS group/ backporters #1012

marco-ippolito opened this issue May 30, 2024 · 2 comments · Fixed by #1037
Labels
Release-agenda

Comments

@marco-ippolito
Copy link
Member

marco-ippolito commented May 30, 2024 •
edited
Loading

Quoting documentation https://github.com/nodejs/Release/blob/main/GOVERNANCE.md:

LTS:

For releasing on LTS release lines, releasers must:

Be added as members of the GitHub [LTS team](https://github.com/orgs/nodejs/teams/lts)
Fully release at least one Current Node.js release; for practice, and to help promote the new GPG key to the user ecosystem prior to it being required to verify an LTS release

Backporters https://github.com/nodejs/Release?tab=readme-ov-file#lts-staging-branches:

Only members of @nodejs/backporters should land commits onto staging branches.

Currently we are not enforcing both of these rules.
I think we should remove the LTS team and keep only releasers, and keep the backporters for people who want to start getting involved with the release working group and can prepare current releases.
@richardlau
Copy link
Member

There's some previous discussion in #912. That also proposed removing backporters.

As I mentioned in #912 (comment) the LTS team has never been, as far as I am aware, an access control team. releasers and backporters are access control teams (e.g. being in releasers would get you access to the release CI and backporters have permissions to push to the LTS staging branches).

I think it's fair to have a discussion as to whether the LTS team serves a purpose today. Our README currently says:

Release/README.md

Lines 93 to 95 in 17c98b4

The Long Term Support (LTS) team manages the process/content of LTS releases
and the required backporting for these releases. Additions to the LTS
team needs sign off from the rest of the LTS team.

and I guess it's debatable whether you can manage the process/content for releases without being a releaser or backporter. You could certainly have an opinion on what could/should be in a LTS release line and how often releases should happen as a general consumer of Node.js.

One thing I would stress is that membership of the Release WG does not equate to being a releaser:

Release/README.md

Lines 81 to 87 in 17c98b4

The Release working group is structured into teams and membership in
the working group does not automatically result in membership in these
teams. These teams are:
* Releasers team
* LTS team
* CITGM team

@mhdawson mhdawson mentioned this issue Jun 24, 2024
Closed
@mhdawson mhdawson mentioned this issue Jul 22, 2024
Open
@marco-ippolito
Copy link
Member Author

In meeting #1026 we had consensus about removing the @nodejs/lts team, and merge it into @nodejs/releasers

@mhdawson mhdawson mentioned this issue Sep 16, 2024
Closed
@marco-ippolito marco-ippolito mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release-agenda
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove lts team nodejs/Release
2 participants
@richardlau @marco-ippolito