Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider endorsing/using Sigstore #642

Open
BethGriggs opened this issue Jan 27, 2021 · 4 comments
Open

Consider endorsing/using Sigstore #642

BethGriggs opened this issue Jan 27, 2021 · 4 comments
Assignees

Comments

@BethGriggs
Copy link
Member

BethGriggs commented Jan 27, 2021

Proposal/Exploration document: Sigstore for Node.js binaries

I believe it is important to reflect on the fundamental problems we are seeking to address and whether Sigstore tooling helps us to solve them. I've heard various community members suggest for us to adopt Sigstore tooling - I'm curious to hear the origins of those suggestions. So, my main ask is:

  • What are the problems that we're trying to solve?
  • How do we believe Sigstore is solving them?

While there are some potential benefits, from my exploration there are also tradeoffs to consider such as:

  • What does this provide to end-users in comparison to our current method of signing and verifying with GPG keys?
  • How many users will benefit from it?
  • Effort/cost of migrating to new tooling.
  • Concerns raised around delegation of trust.

Anyone with an interest, please free to review this Sigstore for Node.js binaries document. The current state of that document is somewhere between a personal scratch-pad of notes and an evolving proposal draft. I hope for that document to eventually help us converge on a decision or outcome of whether we feel Sigstore would add value for the Node.js project to adopt (or not).

cc groups that may have opinions: @nodejs/release, @nodejs/build, @nodejs/security, @nodejs/tsc


Initial suggestion

Chatting with some of the folks working on Rekor (https://rekor.dev/get_started/), they've suggested that it might be something we wish to explore/endorse for Node.js releases.

I will likely not explain it as well as the Rekor folks, but the ledger would be a source of truth for the URL, SHA, Public Key, and Signature of our releases that users can validate against. I believe there is also alerting we could set up - for example, if an old/previous release key was used to sign a release.

They have offered to give us an overview if there's interest. I also believe they've prototyped a ledger for Node.js releases.

cc: @nodejs/build

also cc (from rekor): @bobcallaway @dlorenc @lukehinds

@lukehinds
Copy link

Thanks for raising this @BethGriggs , sure we are happy to come onto a call or we can take questions in here, whichever the community prefers.

@richardlau
Copy link
Member

There's a presentation https://www.youtube.com/watch?v=3LKHKpcH2x8

@BethGriggs BethGriggs changed the title Consider endorsing/using Rekor as release ledger Consider endorsing/using SigStore as release ledger Oct 24, 2022
@BethGriggs BethGriggs self-assigned this Nov 23, 2022
@BethGriggs BethGriggs changed the title Consider endorsing/using SigStore as release ledger Consider endorsing/using SigStore Mar 14, 2023
@BethGriggs BethGriggs changed the title Consider endorsing/using SigStore Consider endorsing/using Sigstore Mar 14, 2023
@BethGriggs
Copy link
Member Author

BethGriggs commented Mar 14, 2023

I have been exploring the feasibility of utilizing Sigstore tooling for signing Node.js binaries (with initial assistance from @lukehinds).

While there are some potential benefits, from my exploration there are also tradeoffs to consider such as:

  • What does this provide to end-users in comparison to our current method of signing and verifying with GPG keys?
  • How many users will benefit from it?
  • Effort/cost of migrating to new tooling.
  • Concerns raised around delegation of trust.

I believe it is important to reflect on the fundamental problems we are seeking to address and whether Sigstore tooling helps us to solve them. I've heard various community members suggest for us to adopt Sigstore tooling - I'm curious to hear the origins of those suggestions. So, my main ask is:

  • What are the problems that we're trying to solve?
  • How do we believe Sigstore is solving them?

Anyone with an interest, please free to review this Sigstore for Node.js binaries document. The current state of that document is somewhere between a personal scratch-pad of notes and an evolving proposal draft. I hope for that document to eventually help us converge on a decision or outcome of whether we feel Sigstore would add value for the Node.js project to adopt (or not).

cc groups that may have opinions: @nodejs/release, @nodejs/build, @nodejs/tsc

I'm going to add this to the issue description so it's not as buried.

@RafaelGSS
Copy link
Member

cc :@nodejs/security-wg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants