Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logic and rename IsCustomerShoppingCartEmpty method #7531

Open
skoshelev opened this issue Jan 30, 2025 · 1 comment
Open

Change logic and rename IsCustomerShoppingCartEmpty method #7531

skoshelev opened this issue Jan 30, 2025 · 1 comment
Labels
on hold / maybe wont

Comments

@skoshelev
Copy link
Contributor

skoshelev commented Jan 30, 2025 •
edited by AndreiMaz
Loading

Currently, the method is called IsCustomerShoppingCartEmpty and returns the inverted result of the Any method. However, in our code it is used to set the HasShoppingCartItems property, i.e. it is called each time with the inverted result.

I think it would be more correct to rename the method to HasShoppingCartItems and get rid of the double inversion
@G3r4rd00
Copy link

@skoshelev I'd like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold / maybe wont
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@G3r4rd00 @AndreiMaz @skoshelev