Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CertRevocationResult.ServerResults and replace it with CertRevocationResult.OCSPResults #222

Open
JeyJeyGao opened this issue Aug 20, 2024 · 1 comment
Open

Deprecate CertRevocationResult.ServerResults and replace it with CertRevocationResult.OCSPResults #222

JeyJeyGao opened this issue Aug 20, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
2.0.0

Comments

@JeyJeyGao
Copy link
Contributor

What is not working as expected?

Since we will introduce CRL in CertRevocationResult to differentiate between CRLResults and OCSPResults, we may need to deprecate ServerResults to make it clearer.

This suggestion was originally mentioned here: https://github.com/notaryproject/notation-core-go/pull/214/files#r1721280510

What did you expect to happen?

No

How can we reproduce it?

No

Describe your environment

source code

What is the version of your notation-core-go Library?

v1.1.0-rc.1
@JeyJeyGao JeyJeyGao added the enhancement New feature or request label Aug 20, 2024
@JeyJeyGao JeyJeyGao mentioned this issue Aug 20, 2024
Merged
@Two-Hearts Two-Hearts modified the milestone: 1.3.0 Aug 20, 2024
@Two-Hearts
Copy link
Contributor

Two-Hearts commented Aug 21, 2024 •
edited
Loading

Given this is deprecating a field of a struct, to avoid breaking change, we still need to fill this deprecated field while initializing Result instances. This can be done in the next major version of notation-core-go by directly renaming ServerResults to OCSPResults.

@Two-Hearts Two-Hearts added the triage triage label Aug 21, 2024
@yizha1 yizha1 removed the triage triage label Sep 3, 2024
@yizha1 yizha1 added this to the Future milestone Sep 3, 2024
@yizha1 yizha1 modified the milestones: Future, 2.0.0 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@JeyJeyGao @yizha1 @Two-Hearts