Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check validity of applicable TP and TS before fetching signatures from registry. #790

Open
priteshbandi opened this issue Sep 26, 2023 · 1 comment
Labels
bug Something isn't working error message Issues related to error message improvement perf Performance related issues
Milestone

Comments

@priteshbandi
Copy link
Contributor

priteshbandi commented Sep 26, 2023

Context: #771 (comment)
Currently signature verification process in Notation, involves fetching the signature and subsequently validating the trust store's vakidity. However, this method has the following concerns:

  1. The error messages provided to users in case of verification failure are not very user-friendly. (Refer to the link above for examples)
  2. If either the Trust Store (TS) or Trust Policy (TP) is malformed, signature validation will always fail. This renders the fetching and validation of signatures unnecessary. Essentially, we're advocating for fast fail.

Ambiguous Specification
Presently, there exists specifications that introduces a conflicting requirement. In one instance, we state that before commencing signature verification, both the TS and TP should be valid, while in other, this is not explicitly emphasized.

Recommended Solution

  1. Amend the specification to state: "User has configured a valid trust store and trust policy."
  2. Make a code change to validate the relevant TS and TP before obtaining the signature. Here, 'relevant' refers to the TP and TS identified for a specific scope.
@priteshbandi priteshbandi added bug Something isn't working triage Need to triage labels Sep 26, 2023
@yizha1 yizha1 added question General Q&A for product usage and removed triage Need to triage labels Oct 17, 2023
Copy link

This issue is stale because it has been opened for 60 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 22, 2024
@yizha1 yizha1 added this to the Future milestone Mar 22, 2024
@yizha1 yizha1 removed the Stale label Mar 22, 2024
@yizha1 yizha1 added error message Issues related to error message improvement perf Performance related issues and removed question General Q&A for product usage labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working error message Issues related to error message improvement perf Performance related issues
Projects
Status: Todo
Development

No branches or pull requests

2 participants