Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nx-cloud] Missing possibility to set env variables for GitHub VCS integration on frontend pods #138

Open
minijus opened this issue Oct 4, 2024 · 0 comments

Comments

@minijus
Copy link
Contributor

minijus commented Oct 4, 2024

Today frontend deployment template allows setting only explicit env values or directly from .env property in values.yaml (plain text, not good for secrets).

With this setup it is not possible to set required env variables for GitHub VCS integration from secret. Documentation defines a way to set these values, but the code does not seem to do it.

Proposed solutions:

  1. Add support for envFrom. This would allow to set env from secrets or configMaps without a need to remap names in values.yaml
  2. Add missing env values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant