Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in project.json working inconsistently #28775

Open
1 of 4 tasks
ipassynk opened this issue Nov 3, 2024 · 0 comments
Open
1 of 4 tasks

Comments in project.json working inconsistently #28775

ipassynk opened this issue Nov 3, 2024 · 0 comments

Comments

@ipassynk
Copy link

ipassynk commented Nov 3, 2024

Current Behavior

Comments (//) in project.json does not work inside options but if move above - works

Works here:

 "serve": {
      "// executor": "@angular-builders/custom-esbuild:dev-server",
      "// {projectRoot}/esbuild/proxy-mocks.ts":  "",
      "executor": "@nx/angular:dev-server",
      "options": {
        "esbuildMiddleware": [
          "{projectRoot}/esbuild/proxy-environment.ts"
        ],

But does not work here:

"serve": {
      "executor": "@nx/angular:dev-server",
      "options": {
        "// {projectRoot}/esbuild/proxy-mocks.ts":  "",
        "esbuildMiddleware": [
          "{projectRoot}/esbuild/proxy-environment.ts"
        ],
        "host": "localhost.xxxx.com"
      },

Expected Behavior

Should work inside options

GitHub Repo

No response

Steps to Reproduce

Add "// {projectRoot}/esbuild/proxy-mocks.ts": "" line inside options

Nx Report

Node : 20.18.0
OS : darwin-x64
Native Target : x86_64-macos
npm : 10.8.2

nx : 20.0.7
@nx/js : 20.0.7
@nx/jest : 20.0.7
@nx/eslint : 20.0.7
@nx/workspace : 20.0.7
@nx/angular : 20.0.7
@nx/devkit : 20.0.7
@nx/esbuild : 20.0.7
@nx/eslint-plugin : 20.0.7
@nx/playwright : 20.0.7
@nx/vite : 20.0.7
@nx/web : 20.0.7
@nx/webpack : 20.0.7
typescript : 5.6.3

Registered Plugins:
@nx/playwright/plugin
@nx/eslint/plugin

Failure Logs

'// {projectRoot}/esbuild/proxy-mocks.ts' is not found in schema

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant