Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify dependency management options for buildable Node libraries #28799

Open
1 of 4 tasks
DarylLyonsLF opened this issue Nov 5, 2024 · 0 comments
Open
1 of 4 tasks

Comments

@DarylLyonsLF
Copy link

DarylLyonsLF commented Nov 5, 2024

Documentation issue

  • Reporting a typo
  • Reporting a documentation bug
  • Documentation improvement
  • Documentation feedback

Is there a specific documentation page you are reporting?

https://nx.dev/concepts/decisions/dependency-management
https://nx.dev/ci/recipes/other/ci-deployment

Additional context or description

#19543 dropped support for generating package.json files during execution of @nx/js:tsc. The recommendation is to use @nx/dependency-checks instead.

This change results in package.json files existing on buildable Node libs where they weren't required before.

Nx docs relating to dep management seem to overlook this change. E.g.

  1. https://nx.dev/concepts/decisions/dependency-management#single-version-policy
    Doesn't account for buildable lib's and is misleading in this context:

    Individual projects may still have package.json files, but they are used only for the metadata defined there, not as a way of defining the dependencies of that project.

  2. https://nx.dev/ci/recipes/other/ci-deployment
    This page is linked from the single version policy page (above). It only accounts for application deployment - where can I find information on publishing lib's through CI, or options for managing their dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant