Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe: Load TypeScript types from stripe-js, NOT from @types #299

Closed
MickL opened this issue Oct 12, 2024 · 0 comments · Fixed by #300
Closed

Stripe: Load TypeScript types from stripe-js, NOT from @types #299

MickL opened this issue Oct 12, 2024 · 0 comments · Fixed by #300
Labels
bug Something isn't working

Comments

@MickL
Copy link
Contributor

MickL commented Oct 12, 2024 •
edited
Loading

🆒 Your use case

I just figured out that the types dont contain stripe.initEmbeddedCheckout(). When looking for the type definitions I saw that the repo for @types/stripe-v3 doesnt exist anymore, last publish was 8 months ago.

The docs say that @stripe/stripe-js already contains types:
https://github.com/stripe/stripe-js?tab=readme-ov-file#typescript-support

It seems to be that they dropped support for @types/stripe-v3. Therefor, can we replace type definitions from the official package please?
@MickL MickL added the enhancement New feature or request label Oct 12, 2024
@huang-julien huang-julien added bug Something isn't working and removed enhancement New feature or request labels Oct 13, 2024
@huang-julien huang-julien mentioned this issue Oct 13, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stripe): prefer @stripe/stripe-js over @types/stripe-v3 nuxt/scripts
2 participants
@MickL @huang-julien