You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
implements an atomic int using a heavy mutex. Using the appropriate atomic datatype would be less surprising. This isn't in a performance critical section of code, so it's not a big issue. It's just a little linty.
But really, why is this one variable atomic? Shouldn't the entire block be protected by a mutex if there's larger global state modification going on?
The text was updated successfully, but these errors were encountered:
In
rpc/server.go
implements an atomic int using a heavy mutex. Using the appropriate atomic datatype would be less surprising. This isn't in a performance critical section of code, so it's not a big issue. It's just a little linty.
But really, why is this one variable atomic? Shouldn't the entire block be protected by a mutex if there's larger global state modification going on?
The text was updated successfully, but these errors were encountered: