feat: allow empty to field in eth_call to simulate contract deploy
#544
Conversation
CedarMist
force-pushed
the
CedarMist/eth_call-deployment
branch
from
69b3054
to
fe440e0
Compare
| @@ -371,7 +371,8 @@ func (api *publicAPI) Call(ctx context.Context, args utils.TransactionArgs, bloc | |||
| ) | |||
|
|
|||
| if args.To == nil { | |||
| return []byte{}, errors.New("to address not specified") | |||
| // When simulating a contract deploy the To address may not be specified | |||
| args.To = &common.Address{} | |||
There was a problem hiding this comment.
So this sets the addres to 0x0000000000000000000000000000000000000000, i think this should be nil. Does the runtime fail with nil to address? Should the runtime handle it?
There was a problem hiding this comment.
When I set To to nil I get:
error: { code: -32603, message: 'method handler crashed' }
Whereas setting it to all zeros the call succeeds.
I'm having another look at eth_call in runtime SDK, it's looking like we might need a separate codepath to handle creation.
There was a problem hiding this comment.
I think it should be fine to set it to 0x000... here for now, since fixing (and deploying) it in runtime will take some time in any case 👍 Maybe just open a clickup issue to check if this should be addressed in oasis-sdk.
| @@ -371,7 +371,8 @@ func (api *publicAPI) Call(ctx context.Context, args utils.TransactionArgs, bloc | |||
| ) | |||
|
|
|||
| if args.To == nil { | |||
| return []byte{}, errors.New("to address not specified") | |||
| // When simulating a contract deploy the To address may not be specified | |||
There was a problem hiding this comment.
Also, this should only be allowed if len(args.data()) != 0 (this is a contract deploy).
|
This workaround is not good. |
Closes #543