Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sapphire-wagmi-v2: Add EIP-6963 support #499

Open
lubej opened this issue Feb 13, 2025 · 0 comments
Open

sapphire-wagmi-v2: Add EIP-6963 support #499

lubej opened this issue Feb 13, 2025 · 0 comments

Comments

@lubej
Copy link
Contributor

lubej commented Feb 13, 2025

SUMMARY

Current implementation of @oasisprotocol/sapphire-wagmi-v2 only supports default injected EIP-1193 provider:

Please note that while EIP-6963 (Multi Injected Provider Discovery) is supported by Wagmi it is only possible to wrap the default injected EIP-1193 compatible provider. For this reason you must disable MIPD support in the Wagmi configuration as additional discovered providers will not be Sapphire wrapped.

Currently setting to:

   {
      // ...
      multiInjectedProviderDiscovery: false,
      // ...
   }

Disables EIP-6963 functionality.

ISSUE TYPE
  • Feature request
COMPONENT NAME
ADDITIONAL INFORMATION

Currently it is easy to misuse @oasisprotocol/sapphire-wagmi-v2. If you don't use EIP-1193 injected provider, and use one provided by EIP-6963, could result in provider not being correctly wrapped. Implementing EIP-6963 would result in clearer way of how to use @oasisprotocol/sapphire-wagmi-v2 and package not being misused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant