Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity shows Sapphire ParaTime deposit as "Failed" immediately after performing the transaction #2113

Open
tjanez opened this issue Jan 13, 2025 · 1 comment · May be fixed by #2123
Open

Activity shows Sapphire ParaTime deposit as "Failed" immediately after performing the transaction #2113

tjanez opened this issue Jan 13, 2025 · 1 comment · May be fixed by #2123
Assignees
@lukaw3d
Labels
bug Something isn't working ux Usability, user experience etc.

Comments

@tjanez
Copy link
Member

tjanez commented Jan 13, 2025

Steps to reproduce:

  1. Deposit something into a Sapphire ParaTime account.
  2. Navigate from "ParaTimes" tab back to "Account" tab.
  3. Deposit transaction marked as "Failed" even though it succeeded:
    Screenshot from 2025-01-13 12-25-52
  4. After refreshing (either automatically or by switching to some other tab and going back to the "Account" tab), the same transaction is marked as "Successful":
    Screenshot from 2025-01-13 12-26-20

I think the wallet should not mark the deposit transaction as "Failed" for this interim period of time.
@tjanez tjanez added bug Something isn't working ux Usability, user experience etc. labels Jan 13, 2025
@lukaw3d
Copy link
Member

lukaw3d commented Feb 2, 2025

Caused by one of these

wallet/src/vendors/nexus.ts

Line 263 in 94420f5

status: t.success ? TransactionStatus.Successful : TransactionStatus.Failed,

since
oasisprotocol/explorer#528 (comment)

@lukaw3d lukaw3d self-assigned this Feb 19, 2025
@lukaw3d lukaw3d linked a pull request Feb 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaw3d lukaw3d

Labels
bug Something isn't working ux Usability, user experience etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix paratime transaction status in the first few seconds oasisprotocol/wallet
2 participants
@tjanez @lukaw3d