Leak of FILE descriptor and using nullptr in memset

[safocl]

Operating System Info

Other

Other OS

Archlinux

OBS Studio Version

31.0.1

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://0x0.st/8TfN.txt

OBS Studio Crash Log URL

No response

Expected Behavior

Not leak of FILE descriptor and do not using nullptr in memset (defined behavior).

Current Behavior

Leak of FILE descriptor and using nullptr in memset (undefined behavior).

Steps to Reproduce

1. Compile

Anything else we should know?

obs-studio/deps/libcaption/src/utf8.c

Line 207 in 73725c2

memset(data, '\0', file_size);

but malloc can return nullptr:

obs-studio/deps/libcaption/src/utf8.c

Line 206 in 73725c2

data = (utf8_char_t*)malloc(1 + file_size);

https://en.cppreference.com/w/c/string/byte/memset

The behavior is undefined if dest is a null pointer.

obs-studio/deps/libcaption/src/utf8.c

Line 197 in 73725c2

FILE* file = fopen(path, "r");

FILE is closed in the if closure only:

obs-studio/deps/libcaption/src/utf8.c

Line 219 in 73725c2

fclose(file);

[Fenrirthviti]

libcaption is a depedency, please report upstream: https://github.com/szatmary/libcaption

[safocl]

maybe this dependency needs to be released?? (the last update is a7666c1 · 7 years ago)

[Fenrirthviti]

That has definitely been a consideration, yes.

[safocl]

That has definitely been a consideration, yes.

this dependency is hardcode for this project -- maybe we should fix everything there ourselves?