Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating virtualenvs in an infinite loop #71

Closed
zsol opened this issue Oct 3, 2022 · 3 comments
Closed

Creating virtualenvs in an infinite loop #71

zsol opened this issue Oct 3, 2022 · 3 comments

Comments

@zsol
Copy link

zsol commented Oct 3, 2022

Description

While setting up thx for libcst, I noticed it keeps creating virtualenvs in an endless loop.

Repro:
add this to libcst's pyproject.toml:

[tool.thx]
python_versions = ["3.10"]

[tool.thx.jobs.lint]
run = [
    "./check_copyright.sh",
]

debug logs here

Details

  • OS: Windows
  • Python version: 3.10.4
  • thx version:0.5.1
  • Can you repro on main? dunno
  • Can you repro in a clean virtualenv? yes
@zsol
Copy link
Author

zsol commented Oct 3, 2022

Maybe related to #41 ?

@zsol
Copy link
Author

zsol commented Oct 3, 2022

Ah no, it's because watch mode restarts venv building because during venv building there are filesystem events coming in. thx lint works fine, thx -w lint is b0rken

@amyreese amyreese mentioned this issue May 29, 2024
Merged
amyreese added a commit to amyreese/thx that referenced this issue May 29, 2024
@amyreese
Include .thx virtualenv dir in default watchdog excludes
f0aac69 
This should help prevent changes to the virtualenvs triggering
new runs when using `thx --watch` mode.

Issue omnilib#71
amyreese added a commit that referenced this issue May 29, 2024
@amyreese
Include .thx virtualenv dir in default watchdog excludes (#111)
bd87ba6 
This should help prevent changes to the virtualenvs triggering
new runs when using `thx --watch` mode.

Issue #71
@amyreese
Copy link
Member

I don't have a Windows machine to test on, but I believe this is now fixed in v0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amyreese @zsol