Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recompile oqs everytime cargo build is invoked #216

Open
wucke13 opened this issue Jun 17, 2023 · 2 comments
Open

Don't recompile oqs everytime cargo build is invoked #216

wucke13 opened this issue Jun 17, 2023 · 2 comments
Labels
question Further information is requested

Comments

@wucke13
Copy link
Contributor

wucke13 commented Jun 17, 2023

Currently, the build.rs of oqs-sys is configured so that oqs is recompiled every time cargo build is executed. This really takes the fun away from cargo watch etc., as it blows the time of a cargo build with an already filled target/ to 20 seconds+.

https://doc.rust-lang.org/cargo/reference/build-scripts.html#change-detection provides some guidance on how to refine the behavior in this regard.
@thomwiggers
Copy link
Contributor

This should already be caught by: https://github.com/open-quantum-safe/liboqs-rust/blob/main/oqs-sys/build.rs#L126-L129....

@thomwiggers
Copy link
Contributor

though at least CC should be added to the environment variables, maybe also CMAKE_*

@thomwiggers thomwiggers added the question Further information is requested label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomwiggers @wucke13