Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[target-allocator] Introduce "per zone" allocation strategy to target allocator #3759

Open
rice-junhaoyu opened this issue Mar 1, 2025 · 3 comments · May be fixed by #3760
Open

[target-allocator] Introduce "per zone" allocation strategy to target allocator #3759

rice-junhaoyu opened this issue Mar 1, 2025 · 3 comments · May be fixed by #3760
Assignees
@rice-junhaoyu
Labels
area:target-allocator Issues for target-allocator enhancement New feature or request

Comments

@rice-junhaoyu
Copy link
Contributor

rice-junhaoyu commented Mar 1, 2025 •
edited
Loading

Component(s)

target allocator

Is your feature request related to a problem? Please describe.

Description:

Zone is a common concept in Cloud and important for High Availability. When a zone-1 is down, we don't want to see a collector from zone-1 failing to scrape targets from zone-2 or other healthy zones and causing missing metric datapoints in healthy zones. Each zone should have a way to be isolated.

A per-zone allocation strategy implements an allocation strategy that only assigns targets from a specific zone to collectors from the same zone.

Describe the solution you'd like

My Solution is to develop a new implementation of Allocation Strategy called "per-zone". On a zone awareness enabled node (e.g. AWS EC2), there's a label "topology. kubernetes.io/zone" which can be utilized.
@rice-junhaoyu rice-junhaoyu added enhancement New feature or request needs triage labels Mar 1, 2025
@rice-junhaoyu rice-junhaoyu linked a pull request Mar 1, 2025 that will close this issue
Open
@jaronoff97
Copy link
Contributor

I think rather than introducing a zone specific strategy it would make more sense for us to introduce a partitioned strategy which takes an argument for a partition key. This would allow a user to partition on any key not just zone or node.

@rice-junhaoyu
Copy link
Contributor Author

Hey Jacob, that's really a good idea to have one single partition strategy while making the partition key configurable. I will spend some after-work hours to think about the implementation. Still not sure if this is an easy work.

@atoulme atoulme added area:target-allocator Issues for target-allocator and removed needs triage labels Mar 12, 2025
@rice-junhaoyu
Copy link
Contributor Author

Hey Jacob, sry for my late reply, too busy in my work!

Just a very quick question to make sure we are on the same page.

So we want cfg.AllocationStrategy to be per-partition, while making the partition key a new config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rice-junhaoyu rice-junhaoyu

Labels
area:target-allocator Issues for target-allocator enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@atoulme @jaronoff97 @rice-junhaoyu