Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification: confusing definition of 'm' in 'geometry' (thetaMode version) #290

Open
DanieleSim opened this issue Jan 29, 2025 · 0 comments

Comments

@DanieleSim
Copy link

openPMD standard version: 1.1.0

When trying to implement the basic version of the standard, I stumbled upon this issue.
A cylindrical axially symmetric dataset (using only the zero mode, and hence having in total one single mode) should have shape (1,:,:), as only the real part of the mode 0 is saved.

In 'geometry', thetaMode version:
...the first axis corresponds to the azimuthal mode. (This last axis has length 2m+1, where m is the number of modes used...

These instructions would lead in the example previously mentioned to datasets with shape (3,:,:), which is incorrect.

Proposed change:

...the first axis corresponds to the azimuthal mode. (This last axis has length 2m+1, where m is the value of the highest mode used...

or

...the first axis corresponds to the azimuthal mode. (This last axis has length m, where m is the number of modes used...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant