Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REALLY Support for max_num_results in FileSearchTool #1004

Open
1 task done
metaskills opened this issue Aug 19, 2024 · 3 comments
Open
1 task done

REALLY Support for max_num_results in FileSearchTool #1004

metaskills opened this issue Aug 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@metaskills
Copy link

Confirm this is a Node library issue and not an underlying OpenAI API issue

  • This is an issue with the Node library

Describe the bug

Little to none and conflicting documentation on using max number of results. It was added, removed, changed???

Screenshot 2024-08-18 at 10 20 47 PM

To Reproduce

Try using max file results anywhere.

  • Run options max_num_results
  • Run options file_search.max_num_results
  • Tools file_search.max_num_results

Code snippets

None.

OS

macOS

Node version

v18

Library version

4.56.0

@metaskills metaskills added the bug Something isn't working label Aug 19, 2024
@athyuttamre
Copy link
Collaborator

Hi @metaskills, what is the issue you're running into?

max_num_results can be specified when creating a Run, documented here: https://platform.openai.com/docs/api-reference/runs/createRun#runs-createrun-tools.

The previous issue you linked to was a bug in our OpenAPI spec, where max_num_results was accidentally added to the thread.message.attachments field.

@metaskills
Copy link
Author

metaskills commented Aug 19, 2024

Yup, using the run options was listed in the failure locations above. I can do another test to show you the output for that specific case.

@metaskills
Copy link
Author

Also, you say documented here but noting on that page shows max_num_results much less in attachments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants