Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort on a function call example is confusing #996

Open
1 task done
hax opened this issue Aug 15, 2024 · 0 comments
Open
1 task done

Abort on a function call example is confusing #996

hax opened this issue Aug 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@hax
Copy link

hax commented Aug 15, 2024

Confirm this is a Node library issue and not an underlying OpenAI API issue

  • This is an issue with the Node library

Describe the bug

Current doc "Abort on a function call" is confusing.

In general, I think use abort is not a good thing, we actually need end/finish method.

To Reproduce

The example code actually not work if use { tool_choice: "required" }? It seems await runner.finalFunctionCall() would just throw Error, and all async methods (eg. finalXXX and totalUsage) will throw error anyway after aborted.

Code snippets

No response

OS

macOS

Node version

Node 22

Library version

4.55.7

@hax hax added the bug Something isn't working label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant