Realtime ingest method is constantly updating sensor nodes needlessly

[caparker]

Running the same file repeatedly will result in the sensor nodes being updated every time. And because there is a trigger on that table to records every update it means that we have a table (sensor_nodes_history) that is growing constantly for no reason.

Here is an example output from the ingest process

NOTICE:  total-measurements: 28850, deleted-timescaledb: 0, deleted-future-measurements: 1, deleted-past-measurements: <NULL>, from: 2018-01-01 00:00:00+00, to: 2022-09-26 03:00:00+00, inserted-from: <NULL>, inserted-to: <NULL>, updated-nodes: 3948, inserted-measurements: 0, inserted-measurands: 0, inserted-nodes: 0, rejected-nodes: 0, rejected-systems: 0, rejected-sensors: 0, exported-sensor-days: 0, process-time-ms: 3438.557, source: fetch

And here is the statement that is likely causing the issue. I have not debugged it yet

WITH updates AS (
UPDATE sensor_nodes s SET
    site_name = COALESCE(t.site_name, s.site_name),
    source_name = COALESCE(t.source_name, s.source_name),
    city = COALESCE(t.city, s.city),
    country = COALESCE(t.country, s.country),
    ismobile = COALESCE(t.ismobile, s.ismobile),
    metadata = COALESCE(s.metadata, '{}'::jsonb) || t.metadata,
    geom = COALESCE(t.geom, s.geom),
    modified_on = now()
FROM tempfetchdata_nodes t
WHERE t.sensor_nodes_id = s.sensor_nodes_id AND
(
    (s.geom IS NULL and t.geom IS NOT NULL)
OR

    ROW(
        t.sensor_nodes_id,
        t.ismobile,
        t.site_name,
        t.source_name,
        t.city,
        t.country,
        t.metadata
    ) IS DISTINCT FROM (
        s.sensor_nodes_id,
        s.ismobile,
        s.site_name,
        s.source_name,
        s.city,
        s.country,
        s.metadata
    )
)
RETURNING 1)
SELECT COUNT(1) INTO __updated_nodes
FROM updates;