Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tobira Integration #311

Closed
JulianKniephoff opened this issue Mar 18, 2024 · 6 comments · Fixed by #313 · May be fixed by #878
Closed

Tobira Integration #311

JulianKniephoff opened this issue Mar 18, 2024 · 6 comments · Fixed by #313 · May be fixed by #878
Assignees
@Arnei
Labels
type:enhancement New feature or request

Comments

@JulianKniephoff
Copy link
Member

opencast/opencast#4131 added Tobira integration to the old admin UI. This should be forward-ported.

There might also be some future requirements that can be tracked here.

See also:
@Arnei Arnei added the type:enhancement New feature or request label Mar 18, 2024
@Arnei Arnei mentioned this issue Mar 21, 2024
Merged
@Arnei Arnei self-assigned this Mar 21, 2024
@dagraf
Copy link

dagraf commented Apr 3, 2024 •
edited
Loading

Some additional requirements:

Must requirements:

  • The Tobira tab should also be there for events (in 'Event details'). In order to get the direct link to the video page and to which pages in Tobira do contain this video.
  • It should not only be possible to add series to Tobira when creating a new series, but also afterwards (i.e. when they have already been created).

Should requirements:

  • Optimize solution to (de)select a sub-page during the creation of a series. Suggestion: To select the desired subpage, a check mark must be placed in the desired column.
    Add wording: "A direct link will be available."
  • Optimize solution if a new sub-page is to be created.
    Suggestion:: When a new sub-page is created, I cannot confirm the creation but only undo it (via the red "x", see screenshot). I would suggest offering a green "checkmark" next to the red "x". This is only displayed once I have filled in the mandatory fields. Clicking on it means that the title and path to the sub-page can no longer be edited (but are displayed identically to the other sub-pages).
Bildschirmfoto 2024-04-03 um 15 47 57

@oas777
Copy link

oas777 commented May 18, 2024 •
edited
Loading

On David's suggestions:

  • +1. But what do you mean by "to which pages in Tobira do contain this video."
  • Do you mean selecting a new "target page" i. e. path for publication? If so, I agree and would add that this should also be available for events and include edit the name of path segments (if you're allowed to), for example for correcting an earlier input.
  • Isn't is possible already to select
    image
    and de-select
    image
    a subpage by clicking on its name in the first column (Subpage title)?
  • Formally, the confirmation is in the last line
    image
    which you then confirm by clicking "Next". But your solution is way more intuitive.

@dagraf
Copy link

dagraf commented May 21, 2024 •
edited
Loading

  • But what do you mean by "to which pages in Tobira do contain this video."

See screenshot: For series, there is not only shown the direct link to this series but also the "Pages in Tobira that contain this series". The same should be offered for videos.

Bildschirmfoto 2024-05-21 um 09 16 18
  • Isn't is possible already to select and de-select a subpage by clicking on its name in the first column (Subpage title)?

Yes, it is possible. That's why I wrote "Optimize solution to (de)select a sub-page during the creation of a series".

@oas777
Copy link

oas777 commented Jul 3, 2024

A reminder to @JulianKniephoff to update David and myself about the status of this one. Also, I should mention this one is expected to solve https://gitlab.elan-ev.de/opencast/eth/tobira/-/issues/30 (change URL of publication ex post).

@JulianKniephoff
Copy link
Member Author

We sent the offer and are still waiting for the order from Apereo. :/

This was referenced Aug 12, 2024
Merged
Merged
Open
@Arnei Arnei closed this as completed in #313 Sep 5, 2024
LukasKalbertodt added a commit to elan-ev/tobira that referenced this issue Oct 8, 2024
@LukasKalbertodt
Change mount_series endpoint to accept and move existing series (#1225
fe23b4e 
)

This is necessary for an upcoming admin UI feature which will allow
admins to change the path of series pages with no other blocks (part of
opencast/opencast-admin-interface#311).

This shouldn't break any existing behaviour.
Related Opencast and admin UI PRs:
opencast/opencast#6091,
opencast/opencast-admin-interface#878.
@oas777 oas777 mentioned this issue Oct 25, 2024
Open
@JulianKniephoff
Copy link
Member Author

Since this seems to keep causing confusion in other communication channels I would like to clarify again that this issue was only about porting the Tobira integration that existed in the old admin UI to the new one. Hence it is solved by #313. This has nothing to do with the additional features requested by @dagraf.

Most, if not all, of these are addressed by #878 and the accompanying PRs for Tobira and Opencast. If it does not cover some requirement, and there isn't an issue for that, yet, we should create it and integrate it in our plan.

Some further issues/requirements already exist in the Tobira repository:

/cc @oas777

KatrinIhler added a commit to opencast/opencast that referenced this issue Oct 29, 2024
@KatrinIhler
Add more admin-UI Tobira endpoints (#6091)
70e291a 
This adds
 - a) an endpoint to get paths of pages in Tobira that host an event
 - b) an endpoint to update the path of a series in Tobira

This shouldn't break any existing behaviour.

These are needed for additional requirements of
opencast/opencast-admin-interface#311.
Corresponding Tobira and admin-UI PRs:
elan-ev/tobira#1225,
opencast/opencast-admin-interface#878.

### Your pull request should…

* [ ] have a concise title
* [ ] [close an accompanying
issue](https://docs.opencast.org/develop/developer/#participate/development-process/#automatically-closing-issues-when-a-pr-is-merged)
if one exists
* [ ] [be against the correct
branch](https://docs.opencast.org/develop/developer/development-process#acceptance-criteria-for-patches-in-different-versions)
* [ ] include migration scripts and documentation, if appropriate
* [ ] pass automated tests
* [ ] have a clean commit history
* [ ] [have proper commit messages (title and body) for all
commits](https://medium.com/@steveamaza/e028865e5791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arnei Arnei

Labels
type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@JulianKniephoff @oas777 @Arnei @dagraf