libct: we should set envs after we are in the jail of the container #4693
+38
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifubang
added
regression
backport/1.3-todo
lifubang
force-pushed
the
fix-home-env-check-set
branch
2 times, most recently
from
2c1ab94 to
409b8fa
Compare
lifubang
force-pushed
the
fix-home-env-check-set
branch
2 times, most recently
from
43d6f21 to
6869606
Compare
rata
reviewed
Mar 25, 2025
tests/integration/run.bats
Outdated
|
|
||
| # https://github.com/opencontainers/runc/issues/4688 | ||
| @test "runc run check default home" { | ||
| requires root |
There was a problem hiding this comment.
IMHO it does not; instead, it should use
[ $EUID -ne 0 ] && requires rootless_idmap
kolyshkin
approved these changes
Mar 25, 2025
lifubang
force-pushed
the
fix-home-env-check-set
branch
from
6869606 to
d8bdf54
Compare
kolyshkin
force-pushed
the
fix-home-env-check-set
branch
from
d8bdf54 to
0823f14
Compare
kolyshkin
approved these changes
Mar 26, 2025
rata
approved these changes
Mar 31, 2025
lifubang
force-pushed
the
fix-home-env-check-set
branch
from
0823f14 to
dabe9cb
Compare
rata
approved these changes
Apr 1, 2025
Signed-off-by: lifubang <[email protected]>
Because we have to set a default HOME env for the current container user, so we should set it after we are in the jail of the container, or else we'll use host's `/etc/passwd` to get a wrong HOME value. Please see: opencontainers#4688. Signed-off-by: lifubang <[email protected]>
lifubang
force-pushed
the
fix-home-env-check-set
branch
from
dabe9cb to
bf38646
Compare
|
@lifubang Can you open a backport to 1.3? |
|
1.3 backport: #4706 |
kolyshkin
removed
the
backport/1.3-todo
kolyshkin
added
the
backport/1.3-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we have to set a default HOME env for the current container user, so we should set it after we are in the jail of the container, or else we'll use host's
/etc/passwdto get a wrong HOME value.Fixes #4688.