Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Enabling ShardIndexingPressureMetricsCollector by default #568

Open
psychbot opened this issue Mar 2, 2021 · 0 comments
Open

Enabling ShardIndexingPressureMetricsCollector by default #568

psychbot opened this issue Mar 2, 2021 · 0 comments

Comments

@psychbot
Copy link
Member

psychbot commented Mar 2, 2021

We want to enable the ShardIndexingPressure Collector to be enabled by default.

These are scenarios which we have tested and have positive result from code perspective -

  1. ShardIndexingPressure enabled and Collector enabled - Will collect metrics.
  2. ShardIndexingPressure disabled and Collector enabled - Will not collect metrics.
  3. ShardIndexingPressure enabled/disabled and and Collector disabled - Will not collect metrics.

ShardIndexingPressure feature can be toggled as per the need and it will take affect in PA as the collector is enabled by default.
Also we have the andon cord to disable this collector in case something goes really wrong
Chances of things going wrong is really low because of below reasons -

  1. This collector will be added to the scheduled metrics collector only when the ShardIndexingPressure class is present in the code.
  2. This collector will process only 50 elements from hot objects - Adding a additional check to just process first 50 objects of hot store performance-analyzer#284
  3. This feature is available for newer versions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant