Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldset template should have the "ecl-form-group" class #1211

Open
arismag opened this issue Nov 14, 2022 · 0 comments
Open

Fieldset template should have the "ecl-form-group" class #1211

arismag opened this issue Nov 14, 2022 · 0 comments

Comments

@arismag
Copy link

arismag commented Nov 14, 2022

Fieldset template should have the "ecl-form-group" class set on:

oe_theme/templates/form/fieldset.html.twig

This how it is set on ecl. If left as is, the fieldset element inherits browser style.

In any case an implementation as on oe_theme/templates/form/select.html.twig is really helpful in such cases since you override only the classes and not the full template, so it's more likely not to lose anything and next updates.

{# Set default wrapper classes. #}
{# This also allows overriding templates to take control of classes like width modifiers. #}
{% set wrapper_classes = wrapper_classes|default([
  'ecl-select__container',
  'ecl-select__container--m',
]) %}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant