Skip to content

Commit 6f6bce5

Browse files
committed
8344559: Log is spammed by missing pandoc warnings when building man pages
Reviewed-by: shade, erikj
1 parent 5f30a8d commit 6f6bce5

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

doc/building.html

+5-5
Original file line numberDiff line numberDiff line change
@@ -863,12 +863,12 @@ <h3 id="gnu-bash">GNU Bash</h3>
863863
are supported.</p>
864864
<p>At least version 3.2 of GNU Bash must be used.</p>
865865
<h3 id="graphviz-and-pandoc">Graphviz and Pandoc</h3>
866-
<p>In order to build the full docs (see the
866+
<p>In order to build man pages and the full docs (see the
867867
<code>--enable-full-docs</code> configure option) <a
868-
href="https://www.graphviz.org">Graphviz</a> and <a
869-
href="https://pandoc.org">Pandoc</a> are required. Any recent versions
870-
should work. For reference, and subject to change, Oracle builds use
871-
Graphviz 9.0.0 and Pandoc 2.19.2.</p>
868+
href="https://pandoc.org">Pandoc</a> is required. For full docs also <a
869+
href="https://www.graphviz.org">Graphviz</a> is required. Any recent
870+
versions should work. For reference, and subject to change, Oracle
871+
builds use Graphviz 9.0.0 and Pandoc 2.19.2.</p>
872872
<h2 id="running-configure">Running Configure</h2>
873873
<p>To build the JDK, you need a "configuration", which consists of a
874874
directory where to store the build output, coupled with information

doc/building.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -680,9 +680,9 @@ At least version 3.2 of GNU Bash must be used.
680680

681681
### Graphviz and Pandoc
682682

683-
In order to build the full docs (see the `--enable-full-docs`
684-
configure option) [Graphviz](https://www.graphviz.org) and
685-
[Pandoc](https://pandoc.org) are required. Any recent versions should
683+
In order to build man pages and the full docs (see the `--enable-full-docs`
684+
configure option) [Pandoc](https://pandoc.org) is required. For full docs also
685+
[Graphviz](https://www.graphviz.org) is required. Any recent versions should
686686
work. For reference, and subject to change, Oracle builds use Graphviz
687687
9.0.0 and Pandoc 2.19.2.
688688

make/autoconf/jdk-options.m4

+2-2
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,15 @@ AC_DEFUN_ONCE([JDKOPT_SETUP_JDK_OPTIONS],
121121
if test "x$DOT" != "x"; then
122122
AC_MSG_RESULT([yes])
123123
else
124-
AC_MSG_RESULT([no, cannot generate full docs])
124+
AC_MSG_RESULT([no, cannot generate full docs or man pages])
125125
FULL_DOCS_AVAILABLE=false
126126
fi
127127
128128
AC_MSG_CHECKING([for pandoc])
129129
if test "x$ENABLE_PANDOC" = "xtrue"; then
130130
AC_MSG_RESULT([yes])
131131
else
132-
AC_MSG_RESULT([no, cannot generate full docs])
132+
AC_MSG_RESULT([no, cannot generate full docs or man pages])
133133
FULL_DOCS_AVAILABLE=false
134134
fi
135135

make/common/modules/LauncherCommon.gmk

+1-3
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,7 @@ ifeq ($(call isTargetOsType, unix)+$(MAKEFILE_PREFIX), true+Launcher)
192192
MAN_FILES_MD := $(wildcard $(addsuffix /*.md, $(call FindModuleManDirs, $(MODULE))))
193193

194194
ifneq ($(MAN_FILES_MD), )
195-
ifeq ($(ENABLE_PANDOC), false)
196-
$(info Warning: pandoc not found. Not generating man pages)
197-
else
195+
ifeq ($(ENABLE_PANDOC), true)
198196
# Create dynamic man pages from markdown using pandoc. We need
199197
# PANDOC_TROFF_MANPAGE_FILTER, a wrapper around
200198
# PANDOC_TROFF_MANPAGE_FILTER_JAVASCRIPT. This is created by buildtools-jdk.

0 commit comments

Comments
 (0)