Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] DCO gets double-signed #106

Open
kavilla opened this issue Nov 9, 2022 · 1 comment
Open

[BUG] DCO gets double-signed #106

kavilla opened this issue Nov 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@kavilla
Copy link
Member

kavilla commented Nov 9, 2022 •
edited
Loading

DCO check will fail if the commit is not signed but it seems when merging the PR it will also sign it again with the author. For example, you can see in the OpenSearch Dashboards repo: https://github.com/opensearch-project/OpenSearch-Dashboards/commits/main. The commits all have the signed off by twice.

I checked in our settings and I can't seem to disable the signing when merging so is this an OpenSearch project wide thing? I noticed the OpenSearch repo also has double signing.
@kavilla kavilla added bug Something isn't working untriaged labels Nov 9, 2022
@dblock
Copy link
Member

dblock commented Nov 10, 2022

I noticed that too. Want to open an issue in the DCO GHA repo?

@dblock dblock removed the untriaged label Nov 10, 2022
@dblock dblock changed the title [BUG] double signing issue [BUG] DCO gets double-signed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @kavilla