Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expand the use of ApproximatePointRangeQuery to other numeric ranges(int, long, float etc) #14406

Open
harshavamsi opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance v2.18.0 Issues and PRs related to version 2.18.0 v2.19.0 Issues and PRs related to version 2.19.0

Comments

@harshavamsi
Copy link
Contributor

Is your feature request related to a problem? Please describe

In #13788, we added support for approximating range queries(computing 10K hits). I did this in an incremental way and added support for only date range queries to limit the exposure since these are sensitive queries. We should incrementally expand support for all the numeric field types.

Describe the solution you'd like

Expand all current implementations of IndexOrDocValuesQuerys used in the number field type range queries to be wrapped in the ApproximateableQuery and use the ApproximatePointRangeQuery along with PointRangeQuery. Similar to #13788 we can make a decision on which query to use during search time in ContextIndexSearcher and rewrite the weight appropriately.

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response

@harshavamsi harshavamsi added enhancement Enhancement or improvement to existing feature or request untriaged labels Jun 17, 2024
@mch2 mch2 removed the untriaged label Jun 26, 2024
@mch2 mch2 added the v2.18.0 Issues and PRs related to version 2.18.0 label Sep 16, 2024
@sandeshkr419 sandeshkr419 added the v2.19.0 Issues and PRs related to version 2.19.0 label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance v2.18.0 Issues and PRs related to version 2.18.0 v2.19.0 Issues and PRs related to version 2.19.0
Projects
Status: In Progress
Status: Now(This Quarter)
Development

No branches or pull requests

3 participants