Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Identity FeatureFlag #16024

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Sep 20, 2024

Description

This PR removes the identity feature flag.

The PR is a follow-up to 2 previous PRs:

This PR is a prerequisite for opensearch-project/opensearch-plugins#238 to begin creating issues on individual plugin repos to adopt the new mechanism for system index interaction

There are 2 additional open PRs (1 in core repo and 1 in security repo) that need to be resolved before plugins start to adopt the new mechanism.

  1. Allow Plugins to request to perform cluster actions and index actions with their assigned PluginSubject and prompt on install #15778
  2. Implement new extension points in IdentityPlugin and add ContextProvidingPluginSubject security#4665

Related Issues

Resolves opensearch-project/security#4439

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Copy link
Contributor

❌ Gradle check result for 1a07f98: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1a07f98: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 1a07f98: SUCCESS

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.96%. Comparing base (2b670cc) to head (1a07f98).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16024      +/-   ##
============================================
- Coverage     71.99%   71.96%   -0.04%     
- Complexity    64408    64420      +12     
============================================
  Files          5281     5281              
  Lines        301003   301000       -3     
  Branches      43483    43482       -1     
============================================
- Hits         216721   216624      -97     
- Misses        66522    66627     +105     
+ Partials      17760    17749      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Strengthen System Index Protection in the Plugin Ecosystem
1 participant