Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Request context cancellation is ignored when retryBackoff is configured #539

Closed
zhyu opened this issue May 7, 2024 · 0 comments · Fixed by #540
Closed

[BUG] Request context cancellation is ignored when retryBackoff is configured #539

zhyu opened this issue May 7, 2024 · 0 comments · Fixed by #540
Labels
bug Something isn't working

Comments

@zhyu
Copy link
Contributor

zhyu commented May 7, 2024

When retryBackoff is configured, the client sleeps between retries and ignores request context cancellation.

In short, the same issue as the one in the origin ES client. The fix has not yet been ported to the OpenSearch client
@zhyu zhyu added bug Something isn't working untriaged labels May 7, 2024
zhyu added a commit to zhyu/opensearch-go that referenced this issue May 7, 2024
@zhyu
fix request context cancellation is ignored when retryBackoff (opense…
82d51cb 
…arch-project#539)
@zhyu zhyu mentioned this issue May 7, 2024
Merged
zhyu added a commit to zhyu/opensearch-go that referenced this issue May 8, 2024
@zhyu
fix request context cancellation is ignored when retryBackoff (opense…
7eecc89 
…arch-project#539)

Signed-off-by: zhyu <[email protected]>
@dblock dblock removed the untriaged label May 16, 2024
Jakob3xD pushed a commit to zhyu/opensearch-go that referenced this issue Jul 1, 2024
@zhyu @Jakob3xD
fix request context cancellation is ignored when retryBackoff (opense…
92a2412 
…arch-project#539)

Signed-off-by: zhyu <[email protected]>
Jakob3xD added a commit that referenced this issue Jul 1, 2024
@zhyu @Jakob3xD
fix request context cancellation is ignored when retryBackoff (#539) (#…
4fb1702 
…540)

* fix request context cancellation is ignored when retryBackoff (#539)

Signed-off-by: zhyu <[email protected]>

* fix unexpected sleep after the last retry

Signed-off-by: zhyu <[email protected]>

* add guides on configuring the client with retry and backoff

Signed-off-by: zhyu <[email protected]>

* Update guides/retry_backoff.md

Co-authored-by: Jakob <[email protected]>
Signed-off-by: Yu Zhang <[email protected]>

---------

Signed-off-by: zhyu <[email protected]>
Signed-off-by: Yu Zhang <[email protected]>
Co-authored-by: Jakob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix request context cancellation is ignored when retryBackoff (#539) zhyu/opensearch-go
2 participants
@dblock @zhyu