[BUG] MappingFieldResp struct is not parsed correctly.

[agnivade]

What is the bug?

MappingFieldResp struct is not parsed correctly.

How can one reproduce the bug?

A short snippet

mappingFieldResp, err := client.Indices.Mapping.Field(ctx, &opensearchapi.MappingFieldReq{
		Fields:  []string{"type"},
		Indices: []string{indexName},
	})
	fmt.Println("---------------------")
	io.Copy(os.Stderr, mappingFieldResp.Inspect().Response.Body)
	fmt.Printf("\n%+v\n", mappingFieldResp.Indices)
	fmt.Printf("\n---------------------\n")

prints

---------------------
{"channels":{"mappings":{"type":{"full_name":"type","mapping":{"type":{"type":"keyword"}}}}}}
map[]
---------------------

What is the expected behavior?

It should parse the data correctly

What is your host/environment?

Linux

Do you have any additional context?

The issue is that there is an additional Indices field which is there inside the struct which is not allowing the response to be parsed properly.

Here:

opensearch-go/opensearchapi/api_indices-mapping.go

Line 63 in 6836d76

if data.response, err = c.apiClient.do(ctx, req, &data); err != nil {

, we need to pass data.Indices instead of data.

I am not sure how the unit tests are passing. But it seems like a pretty straightforward bug to me.

EDIT: Something like this works:

var mappingFieldResp map[string]struct {
  Mappings json.RawMessage `json:"mappings"`
}
httpResp, err := es.client.Client.Do(ctx, &opensearchapi.MappingFieldReq{
  Fields:  []string{"type"},
  Indices: []string{indexName},
}, &mappingFieldResp)

[dblock]

Looks like a miss. Want to fix it here?

Also note that we would like to generate the client from spec to catch all this kind of problems (#284), so would be great to check the spec for correctness for this API.

[agnivade]

I can, but currently I have a workaround so it's not urgent for me. I'll see if I can find some time.