Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should button title tooltips apply to the entire button or just the label/icon? #1207

Open
joshuarrrr opened this issue Jan 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@joshuarrrr
Copy link
Member

Is your feature request related to a problem? Please describe.

In #1160, we fixed an issue where icon-only buttons didn't have a tooltip/title attribute to display text on hover. Now that we've fixed that, I noticed that, because the title attribute is only applied to the button content it only activates when hovering directly over the label text or icon. If you hover the part of the button that's mostly padding, you don't get the tooltip hint. See the demo:

Screen.Recording.2024-01-11.at.2.50.50.PM.mov

Describe the solution you'd like

I think the tooltip is especially helpful in cases where users aren't familiar with the icon. But it seems like it would be better to trigger/apply it to the entire button, rather than just the contents. @kgcreative any thoughts or preferences from the UX side?

@BigSamu
Copy link
Contributor

BigSamu commented Jan 12, 2024

@joshuarrrr @BSFishy you can give me this tot ake a look

@joshuarrrr
Copy link
Member Author

I'd like a little more validation that other folks think this is a good idea/worth doing before we invest in it.

@kgcreative
Copy link
Member

for accessibility reasons, it should trigger on hover over the whole button element

@BigSamu
Copy link
Contributor

BigSamu commented Jan 13, 2024

Agree on that. Thinking that in terms of UX experience this better for a user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants