Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] EuiButtonEmpty's iconSize prop is not escaped from the DOM which throws an error in the console #1225

Open
ashwin-pc opened this issue Feb 2, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ashwin-pc
Copy link
Member

Describe the bug

Using the EuiButtonEmpty component's iconSize prop causes react to throw an error because the prop is passed down to the HTML

Screenshot 2024-02-01 at 5 54 54 PM

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

Host/Environment (please complete the following information):

  • OUI Version: [e.g. 1.0]
  • OSD Version (if applicable): [e.g. 2.7.0]
  • OS: [e.g. iOS]
  • Browser and version [e.g. Chrome 90]

Additional context

Add any other context about the problem here.

@ashwin-pc ashwin-pc added bug Something isn't working good first issue Good for newcomers untriaged labels Feb 2, 2024
@dblock dblock removed the untriaged label Jun 17, 2024
@dblock
Copy link
Member

dblock commented Jun 17, 2024

Catch All Triage - 1 2 3 4 5

@AMoo-Miki
Copy link
Collaborator

OuiButtonEmpty declares the type but completely ignores the iconSize prop in its own rendering and hands it down to the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants