Add feature flag for NewOLMPreflightPermissionCheck

tmshort · tmshort · commit 41c6c1c3945c · 2025-03-20T09:51:19.000-04:00
Signed-off-by: Todd Short &lt;todd.short@me.com&gt;
diff --git a/features.md b/features.md
@@ -9,6 +9,7 @@
 | ClusterVersionOperatorConfiguration| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | |  |
 | Example2| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | |  |
 | NewOLMCatalogdAPIV1Metas| | | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span>  |
+| NewOLMPreflightPermissionChecks| | | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span>  |
 | SELinuxChangePolicy| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | |  |
 | SELinuxMount| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | |  |
 | ShortCertRotation| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | |  |
diff --git a/features/features.go b/features/features.go
@@ -538,6 +538,14 @@ var (
 						enableForClusterProfile(SelfManaged, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 						mustRegister()
 
+	FeatureGateNewOLMPreflightPermissionChecks = newFeatureGate("NewOLMPreflightPermissionChecks").
+							reportProblemsToJiraComponent("olm").
+							contactPerson("tshort").
+							productScope(ocpSpecific).
+							enhancementPR("https://github.com/openshift/enhancements/pull/1768").
+							enableForClusterProfile(SelfManaged, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
+							mustRegister()
+
 	FeatureGateInsightsOnDemandDataGather = newFeatureGate("InsightsOnDemandDataGather").
 						reportProblemsToJiraComponent("insights").
 						contactPerson("tremes").
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -133,6 +133,9 @@
                     {
                         "name": "NewOLMCatalogdAPIV1Metas"
                     },
+                    {
+                        "name": "NewOLMPreflightPermissionChecks"
+                    },
                     {
                         "name": "NodeSwap"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -39,6 +39,9 @@
                     {
                         "name": "NewOLMCatalogdAPIV1Metas"
                     }
+                    {
+                        "name": "NewOLMPreflightPermissionChecks"
+                    }
                 ],
                 "enabled": [
                     {
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -45,6 +45,9 @@
                     {
                         "name": "NewOLMCatalogdAPIV1Metas"
                     },
+                    {
+                        "name": "NewOLMPreflightPermissionChecks"
+                    },
                     {
                         "name": "SELinuxChangePolicy"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -133,6 +133,9 @@
                     {
                         "name": "NewOLMCatalogdAPIV1Metas"
                     },
+                    {
+                        "name": "NewOLMPreflightPermissionChecks"
+                    },
                     {
                         "name": "NodeSwap"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -203,6 +203,9 @@
                     {
                         "name": "NewOLMCatalogdAPIV1Metas"
                     },
+                    {
+                        "name": "NewOLMPreflightPermissionChecks"
+                    },
                     {
                         "name": "NodeDisruptionPolicy"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -215,6 +215,9 @@
                     {
                         "name": "NewOLMCatalogdAPIV1Metas"
                     },
+                    {
+                        "name": "NewOLMPreflightPermissionChecks"
+                    },
                     {
                         "name": "NodeDisruptionPolicy"
                     },

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,9 @@`
`133`	`133`	`{`
`134`	`134`	`"name": "NewOLMCatalogdAPIV1Metas"`
`135`	`135`	`},`
	`136`	`+ {`
	`137`	`+ "name": "NewOLMPreflightPermissionChecks"`
	`138`	`+ },`
`136`	`139`	`{`
`137`	`140`	`"name": "NodeSwap"`
`138`	`141`	`},`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,9 @@`
`39`	`39`	`{`
`40`	`40`	`"name": "NewOLMCatalogdAPIV1Metas"`
`41`	`41`	`}`
	`42`	`+ {`
	`43`	`+ "name": "NewOLMPreflightPermissionChecks"`
	`44`	`+ }`
`42`	`45`	`],`
`43`	`46`	`"enabled": [`
`44`	`47`	`{`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,9 @@`
`45`	`45`	`{`
`46`	`46`	`"name": "NewOLMCatalogdAPIV1Metas"`
`47`	`47`	`},`
	`48`	`+ {`
	`49`	`+ "name": "NewOLMPreflightPermissionChecks"`
	`50`	`+ },`
`48`	`51`	`{`
`49`	`52`	`"name": "SELinuxChangePolicy"`
`50`	`53`	`},`
Original file line number	Diff line number	Diff line change
`@@ -203,6 +203,9 @@`
`203`	`203`	`{`
`204`	`204`	`"name": "NewOLMCatalogdAPIV1Metas"`
`205`	`205`	`},`
	`206`	`+ {`
	`207`	`+ "name": "NewOLMPreflightPermissionChecks"`
	`208`	`+ },`
`206`	`209`	`{`
`207`	`210`	`"name": "NodeDisruptionPolicy"`
`208`	`211`	`},`
Original file line number	Diff line number	Diff line change
`@@ -215,6 +215,9 @@`
`215`	`215`	`{`
`216`	`216`	`"name": "NewOLMCatalogdAPIV1Metas"`
`217`	`217`	`},`
	`218`	`+ {`
	`219`	`+ "name": "NewOLMPreflightPermissionChecks"`
	`220`	`+ },`
`218`	`221`	`{`
`219`	`222`	`"name": "NodeDisruptionPolicy"`
`220`	`223`	`},`