Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-1.11-rebase: reenable event handling while image pruning #20127

Open
miminar opened this issue Jun 28, 2018 · 6 comments
Open

post-1.11-rebase: reenable event handling while image pruning #20127

miminar opened this issue Jun 28, 2018 · 6 comments
Assignees
Labels
component/image kind/bug Categorizes issue or PR as related to a bug. kind/post-rebase lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P1 sig/developer-experience

Comments

@miminar
Copy link

miminar commented Jun 28, 2018

Underlying gonum/graph assigns conflicting IDs to new nodes after a node deletion. Thus two different nodes amy be assigned the same ID. This leads to panic when an edge is set between them.

The following PR temporarily disables event handling until the package is fixed. This ensures that no new nodes will be added to the graph after the first node gets removed.

deads2k#87

Either gonum/graph needs to be fixed or some replacement needs to be found.

The code is still buggy in 3.10 and needs to be fixed. The rebase just made the bug visible.

@miminar miminar added kind/bug Categorizes issue or PR as related to a bug. priority/P1 component/image kind/post-rebase labels Jun 28, 2018
@miminar
Copy link
Author

miminar commented Jun 28, 2018

/cc @openshift/sig-developer-experience

@bparees
Copy link
Contributor

bparees commented Jun 28, 2018

we'll also need to fix this behavior in 3.10.z

@bparees
Copy link
Contributor

bparees commented Jun 28, 2018

Does gonum/graph allow us to generate our own ids?

@bparees bparees assigned legionus and unassigned miminar Jun 28, 2018
@miminar
Copy link
Author

miminar commented Jun 28, 2018

Does gonum/graph allow us to generate our own ids?

Good idea. The generation is quite simple: https://github.com/openshift/origin/blob/master/vendor/github.com/gonum/graph/simple/directed.go#L51

We can use our own function though.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2018
@bparees
Copy link
Contributor

bparees commented Sep 26, 2018

/remove-lifecycle stale
/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/image kind/bug Categorizes issue or PR as related to a bug. kind/post-rebase lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P1 sig/developer-experience
Projects
None yet
Development

No branches or pull requests

5 participants