Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PowerSave 2 command to enable RF only sleep on Beken N/T #1533

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Zanadar
Copy link

@Zanadar Zanadar commented Feb 14, 2025

No description provided.

@divadiow
Copy link
Contributor

maybe submit a post about this too for greater visibility?

https://www.elektroda.com/rtvforum/forum390.html

@NonPIayerCharacter
Copy link
Contributor

Remember making this suggestion on elektroda, but i forgot about it.
Btw, comment should be adjusted here:

//cmddetail:"descr":"Enables dynamic power saving mode on Beken N/T, BL602, W600, W800 and LN882H. In the case of LN882H PowerSave will not work as a startup command, so use in autoexec. On LN882H PowerSave 1 = light sleep and Powersave >1 (eg PowerSave 2) = deeper sleep. On LN882H PowerSave 1 should be used if BL0937 metering is present. On all supported platforms PowerSave 0 can be used to disable power saving.",

And not in .md file, as it is regenerated every several months.

@openshwprojects
Copy link
Owner

Very nice, but does it mean that we now have PowerSave 1 and PowerSave 2 with different meanings on different platforms?

Maybe it would be better to change the naming, for example, PowerSaveNoRF or PowerSave NoRF (PowerSave 1 = full powersave, PowerSave 0 = disable, PowerSave NoRF = only mcu sleep)

@Zanadar
Copy link
Author

Zanadar commented Feb 15, 2025

@NonPIayerCharacter thank you for the guidance regarding the comment... I have updated in cmd_main.c as suggested!

@openshwprojects I agree it is not ideal, obviously I did the best I could to add the new function as a minimalistic change whilst remaining non-breaking for the sake of upgrades. I am not sure it is an issue that the PowerSave setting behaves differently on different platforms as I can't imagine configurations would be shared between platforms often. What do you think?
I also see a potential issue with making it non-numeric as I imagine on some platforms it may not be quite as simple as RF vs MCU... for example there could in theory be different mcu power settings available.

@Zanadar
Copy link
Author

Zanadar commented Feb 17, 2025

Is this now approvable?

@divadiow
Copy link
Contributor

Seems like a nice thing to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants