Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotki's first commit is off by more than a year #446

Open
LefterisJP opened this issue Aug 3, 2024 · 2 comments
Open

rotki's first commit is off by more than a year #446

LefterisJP opened this issue Aug 3, 2024 · 2 comments
Assignees
Labels
P1 High priority issue

Comments

@LefterisJP
Copy link

Question: How do you calculate first commit?

rotki's first commit is: rotki/rotki@9c949a2

That's 9th of May 2017.

According to OSS observer first commit is 15-12-2018. Retrieved from: https://www.opensource.observer/project/rotki

2024-08-03_23-58

@ccerv1
Copy link
Member

ccerv1 commented Aug 5, 2024

Interesting ... we use Github archive for historic data. You can also see visualizations from the same dataset here on OSS Insight

image

This shows commits starting in March 2018, but not back to May 2017. But this is also different than what we're showing (December 2018)!

So there are two separate issues:

1. Bug on our end

There's definitely a bug on our end, because our first commit should be the same as OSS Insight / Github archive. I made a change to the underlying model that powers this metric sometime last week, and it must have broke something. Will sort this out!

2. rotki's history

There are a few possible explanations for why your first commit is different than the Github archive record:

  • The pre-2018 commits were made to a repo other than rokti/rotki. Did development begin on some other Github owner or on a repo that's since been deprecated?
  • The pre-2018 commits were made to a private repo that turned public in March 2018.
  • The production branch started out as something like main or master and got renamed to developer in 2018.
  • There's some weird gap in Github archive data from that period.

We have a way of doing backfills to cover gaps in Github archive data, but would like to use that as a last resort since I'm guessing you're not the only one affected by this issue...

@ccerv1 ccerv1 self-assigned this Aug 5, 2024
@ccerv1 ccerv1 added the P1 High priority issue label Aug 5, 2024
@ccerv1
Copy link
Member

ccerv1 commented Aug 14, 2024

We just ran the following:

gh api -H "Accept: application/vnd.github+json"   -H "X-GitHub-Api-Version: 2022-11-28"   /repos/rotki/rotki

and got back:

 "created_at": "2018-03-05T11:26:09Z"

Actions:

  • Include the created_at (and updated_at) fields in ossd.repositories @ravenac95
  • Update the downstream models to include these new fields as well
  • Include created_at in the frontend and update copy for first_commit to indicate is the first public commit merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue
Projects
Status: Blocked
Development

No branches or pull requests

3 participants