Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[invokers / popovers] stopping a video in a popover #1107

Open
brechtDR opened this issue Oct 14, 2024 · 2 comments
Open

[invokers / popovers] stopping a video in a popover #1107

brechtDR opened this issue Oct 14, 2024 · 2 comments
Labels
invokers popover The Popover API

Comments

@brechtDR
Copy link
Collaborator

Recently at a conference someone came with a question to me.

When a video is playing and a popover gets closed, you still hear the video in the background (so it isn't stopped)
This results in an unwanted behaviour in most cases.

I was wondering what would happen when combining popovertarget and commandfor in this case:
Here is a quick codepen link

And (quite understandably as previously discussed) a commandfor takes precedence over the popovertarget.
I understand this as we want popovers to work with invokers as well, but my question is rather about the use case than the "hack" I was trying to pull in that demo.

So a few questions I want to ask, just to make sure we don't forget:

Shouldn't there be a way to kill items playing inside of a popover without the use of JavaScript?
Can we maybe revisit this with invokers?
Is there any way that a video still playing when a popover is closed is a wanted behaviour?
(And when this happens, isn't that just bad A11Y as well, i wonder?)

@brechtDR brechtDR added popover The Popover API invokers labels Oct 14, 2024
@josepharhar
Copy link
Collaborator

Sounds like the same issue as this? https://issues.chromium.org/issues/40281699

@brucelawson
Copy link

yes, same issue; I was chatting with Brecht about this because the original issue fizzled out, but I still think that stopping media playing in a popover when it's dismissed is expected behaviour for 99% of developers, but it isn't possible declaratively at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invokers popover The Popover API
Projects
None yet
Development

No branches or pull requests

3 participants