Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance VolumeStats object with new fields #222

Open
glimchb opened this issue Dec 12, 2022 · 3 comments
Open

enhance VolumeStats object with new fields #222

glimchb opened this issue Dec 12, 2022 · 3 comments
Labels
Storage APIs or code related to storage area

Comments

@glimchb
Copy link
Member

glimchb commented Dec 12, 2022

Consider add:

  • Flush commands count in addition to Read/Write/Unmap
  • Admin commands count in addition to Read/Write/Unmap
  • Error count to every Read/Write/Unmap/Flush/Admin Ops
  • Async event count
  • change from int32 to int64 (comment from @llabordehpe on [storage] define statistics object #220)

@benlwalker @llabordehpe @mkalderon @jainvipin @GottliebNoam @orendu WDYT ?

Some of them applicable to FrontEnd only sand not BackEnd volumes, I think...

see https://github.com/opiproject/opi-marvell-bridge/blob/main/spdk.go#L287 - MrvlNvmGetCtrlrStatsResult
see https://github.com/opiproject/opi-nvidia-bridge/blob/main/spdk.go#L115 - NvdaControllerNvmeStatsResult

@glimchb glimchb added the Storage APIs or code related to storage area label Dec 12, 2022
@jainvipin
Copy link
Contributor

+1 on the idea of adding more stats; how do we make the user aware that some implementation is not supporting all the stats e.g. do we keep them zero? I hope not all stats are mandatory - if not, how do we identify optional and mandatory stats.

@glimchb
Copy link
Member Author

glimchb commented Dec 12, 2022

@jainvipin what from the existing stats or proposed here, you feel should be optional ?

@mkalderon
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage APIs or code related to storage area
Projects
None yet
Development

No branches or pull requests

3 participants