Custom error types doesn't match at custom tests

[RaulBernal]

When I try to run this test:

func TestSupplychainMsgServerDelete(t *testing.T) {
	creator := "A"

	tests := []struct {
		desc    string
		request *types.MsgDeleteSupplychain
		err     error
	}{
		{
			desc:    "Completed",
			request: &types.MsgDeleteSupplychain{Creator: creator},
		},
		{
			desc:    "Unauthorized",
			request: &types.MsgDeleteSupplychain{Creator: "B"},
			err:     types.ErrUnauthorized,
		},
		{
			desc:    "KeyNotFound",
			request: &types.MsgDeleteSupplychain{Creator: creator, Id: 10},
			err:     types.ErrKeyNotFound,
		},
	}
	for _, tc := range tests {
		t.Run(tc.desc, func(t *testing.T) {
			_, srv, ctx := setupMsgServer(t)
			wctx := sdk.UnwrapSDKContext(ctx)

			_, err := srv.CreateSupplychain(wctx, &types.MsgCreateSupplychain{Creator: creator})
			require.NoError(t, err)
			_, err = srv.DeleteSupplychain(wctx, tc.request)
			if tc.err != nil {
				require.ErrorIs(t, err, tc.err)
			} else {
				require.NoError(t, err)
			}
		})
	}
}

I get this output:

=== RUN   TestSupplychainMsgServerDelete/Unauthorized
    /Users/raul/SDK/v0.50/bcna/x/bcna/keeper/msg_server_supplychain_test.go:97:
                Error Trace:    /Users/raul/SDK/v0.50/bcna/x/bcna/keeper/msg_server_supplychain_test.go:97
                Error:          Target error should be in err chain:
                                expected: "incorrect owner: unauthorized"
                                in chain: "incorrect owner: unauthorized"
                                        "unauthorized"
                                        "unauthorized"
                Test:           TestSupplychainMsgServerDelete/Unauthorized
--- FAIL: TestSupplychainMsgServerDelete/Unauthorized (0.00s)

Having errors.go at my module this content:

package types

// DONTCOVER

import (
	sdkerrors "cosmossdk.io/errors"
)

// x/bcna module sentinel errors
var (
	ErrInvalidSigner       = sdkerrors.Register(ModuleName, 1100, "expected gov account as only signer for proposal message")
	ErrDuplicateBitcannaid = sdkerrors.Register(ModuleName, 1101, "BitCannaID already exists")
	ErrKeyNotFound         = sdkerrors.Register(ModuleName, 1102, "Key doesn't exists: key not found")
	ErrUnauthorized        = sdkerrors.Register(ModuleName, 1103, "incorrect owner: unauthorized")
	ErrUnrecognized        = sdkerrors.Register(ModuleName, 1104, "Unrecognized messager")
	ErrInvalidAddress      = sdkerrors.Register(ModuleName, 1105, "invalid address")
	ErrMaxCharacters       = sdkerrors.Register(ModuleName, 1106, "input exceeds the permitted length limit")
)

This happens when I try to use my custom "errors.go" types in place of sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
IDK if is a scaffolding Ignite issue @julienrbrt (because is refactored using it for v0.50)

[julienrbrt]

Can you post how are the error wrapped / returned in DeleteSupplychain?

[RaulBernal]

func (k msgServer) DeleteSupplychain(goCtx context.Context, msg *types.MsgDeleteSupplychain) (*types.MsgDeleteSupplychainResponse, error) {
	ctx := sdk.UnwrapSDKContext(goCtx)

	// Checks that the element exists
	val, found := k.GetSupplychain(ctx, msg.Id)
	if !found {
		return nil, errorsmod.Wrap(sdkerrors.ErrKeyNotFound, fmt.Sprintf("key %d doesn't exist", msg.Id))
	}

	// Checks if the msg creator is the same as the current owner
	if msg.Creator != val.Creator {
		return nil, errorsmod.Wrap(sdkerrors.ErrUnauthorized, "incorrect owner")
	}

	k.RemoveSupplychain(ctx, msg.Id)

	return &types.MsgDeleteSupplychainResponse{}, nil
}

BTW I can bypass this problem using require.Contains(t, err.Error(), tc.err.Error()) but.. is the way when it works fine with sdkerrors.ErrKeyNotFound ?

[RaulBernal]

Ohmm I think I get it... I should change also the error wrapping; something like:

	// Checks that the element exists
	val, found := k.GetSupplychain(ctx, msg.Id)
	if !found {
		return nil, types.ErrKeyNotFound.Wrapf("key doesn't exist: %d", msg.Id)
	}