Explanation of why reviews don't take 30 seconds, even for trivial changes

[tessus]

I am wondering how this project is run. I am curious because I don't know what's going on. I see a few dep updates over the past few weeks, but my PR has been ignored, even though I have made the changes that were requested 3 weeks ago.
But also other PRs (including questions in them) seem to be ignored.

I do understand that devs are working on this in their spare time, but if there's a human resource issue, maybe one can add a pinned issue or discussion to explain the situation.
I also understand that huge PRs take a while to review, but the change that was requested was exclusively about the commit message, which takes like 20-30 seconds to review.

This is not an attempt to mock anyone. I really don't know what's going on, but I would like to.

[cafkafk]

It's simply an issue of time and effort, and your particular PR has already required a lot of explanation. Not that there is anything wrong with that, but that makes them more costly to review. Equally, makes them more valuable for the long term growth of the project, but those things just don't merge fast.

There is probably not a need for a pinned issue as this is a chronic issue that affects all open source. We are very transparent that we are happy to welcome new contributors to the project, specially those that conduct high quality detailed reviews in accordance with our standards.

At our current scale, governance simply isn't a problem. There hasn't ever been an issue we couldn't find a compromise on, and it would be premature to do something more elaborate when we are about 5 committers in total. Those bits we're given out liberally, to people that continuously, and actively contributed, and it's not gatekept very hard.

And just to be clear, you asserting that it takes 20-30 seconds to review is not true. At least not the kinda reviews that are useful for a project like eza, with an userbase like eza's, and with a commitment to some semblance of quality like we have. Reviews here aren't meant to be rubber stamps as in seen more often in industry, they're a vouch for the quality of the code one approves, and the time it takes someone to reach that is even for the simplest changes significantly more time than 30 seconds.

[cafkafk]

Also I try to distribute my time across all contributors equally, according to some vague notion of weighted shorted job first, if you change hasn't been reviewed yet, it's likely because I have had other, more important things to do first. I know it can be frustrating waiting for a review, but I am already keeping this project running with weekly releases and taking care of issues that need interactions NOW, and I ask that you don't foster the kinda rushed burnout culture that leads to e.g. what happened with xz. Not just out of kindness, but as a moderator of this community.

[tessus]

Thanks for the reply and info.

Just to clarify. I was not saying that reviewing in general takes only 30s. I was saying that reviewing my change that you requested takes 30s. You wanted to have a BREAKING footer. I added it. How long does it take to read one line? Reading the entire commit message takes about 30s.

P.S.: The requested change was about the commit message. No code review is necessary anymore. You've done that already. And I haven't changed the code of my PR, only the commit message. Thus it's just the message to review.

[tessus]

All good now. I just didn't know what was going on.

[cafkafk]

If you expect to keep continuing contributing to eza, please stop being so passive aggressive. If it took 30 seconds the review would have been done by now, but so far it has taken both the discussion in that issue of why it was a breaking change, and this entire thread, and last I looked at that PR it was in need of improvements. You keep writing that your messages aren't an attempt to mock anyone or cause issues, but the title of this discussion was initially about governance, and you keep speaking very confidently about matters in which you are consistently wrong.

There are other projects that may be more interesting of you that are accepting of this kind of behavior, but eza is not it.

I will get to your PR when I have time.

[shoaib42]

@cafkafk I apologize for the whole tone and how everyone felt here. And I apologize on @tessus behalf. May we all have a smile that makes our loved ones happy. Shall we put this to rest.

• Maintainer has to juggle, even if its a single word that is change, not everything is fresh to the maintainer, so it sometimes take time.
• Contributor is an enthusiast, adding beauty to something for everyone's benefit. They are eager to see their stroke of art admired.

So no one is wrong here, if one of you carries a blame, the other is the forgiving one!

May you all have blessed days!