Exception updating orm.py

[S03M]

Hello,

Trying to modify my GlobaLeaks app 4.10.18, an exception was thrown in orm.py, one of the modified files. The changes applied to this file is a small part of capturing InvalidAuthentication errors.

And the error that appears is following:

_Version: 4.10.18

NameError Name not found globally.

Traceback (most recent call last):

File "/var/globaleaks/backend/globaleaks/orm.py", line 178, in _wrap

result = function(session, *args, **kwargs)

File "/var/globaleaks/backend/globaleaks/handlers/authentication.py", line 118, in login

if user and not GCE.check_password(password, user.salt, user.hash):

AttributeError: 'User' object has no attribute 'hash'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

File "/var/globaleaks/backend/env/lib64/python3.6/site-packages/twisted/internet/defer.py", line 1416, in _inlineCallbacks

result = result.throwExceptionIntoGenerator(g)

File "/var/globaleaks/backend/env/lib64/python3.6/site-packages/twisted/python/failure.py", line 512, in throwExceptionIntoGenerator

return g.throw(self.type, self.value, self.tb)

File "/var/globaleaks/backend/globaleaks/handlers/authentication.py", line 187, in post

self.request.client_ip)

File "/var/globaleaks/backend/env/lib64/python3.6/site-packages/twisted/python/threadpool.py", line 250, in inContext

result = inContext.theWork()

File "/var/globaleaks/backend/env/lib64/python3.6/site-packages/twisted/python/threadpool.py", line 266, in

inContext.theWork = lambda: context.call(ctx, func, *args, **kw)

File "/var/globaleaks/backend/env/lib64/python3.6/site-packages/twisted/python/context.py", line 122, in callWithContext

return self.currentContext().callWithContext(ctx, func, *args, **kw)

File "/var/globaleaks/backend/env/lib64/python3.6/site-packages/twisted/python/context.py", line 85, in callWithContext

return func(*args,**kw)

File "/var/globaleaks/backend/globaleaks/orm.py", line 193, in _wrap

except errors.InvalidAuthentication:

NameError: name 'errors' is not defined_

Does anyone know why this may be happening or has had a similar excepcion?

Thanks!

[evilaliv3]

Thank you for the question @S03M

I see what you are implementing, it is actually a right point what you are trying to correct and we will evaluate to fix it next developmens.

Regarding your attempt of patch, maybe you are forgetting to import "errors" ?

[S03M]

First of all, thank you very much.

Errors it was imported but it was imported with a not quite correct path and a part of that had to be deleted.
Now it is working correctly, because the image above is the simplest way we have found to make this functionality work.

Thanks!