Should the Plugin or Attacher type be deprecated?

[remcohaszing]

I noticed the Plugin type is an exact alias of Attacher. I wonder if this is done purposely or if one should be removed (or deprecated for backwards compatibility).

[ChristianMurphy]

I wonder if this is done purposely

That goes all the way back to #43, @Rokt33r may be able to comment more on the intent.
My educated guess, is that it reflects that the documentation for Unified uses both terms somewhat interchangeably, and that the aliases are used to match the documentation.

---

if one should be removed (or deprecated for backwards compatibility).

🤔 Out in the community, from what I've seen, Plugin is what I've used most and seen used most.
I'd be open to deprecating Attacher since it isn't frequently used.
Though I can also see another perspective, where it aligns with the documentation, and doesn't seem to be doing any harm (that I have seen), it might be okay to leave it be as well. 🤷‍♂️

Thoughts? 💭

[remcohaszing]

I have been a bit busy lately, but I do want to fix this soon. Should I just remove Attacher then? IMO Plugin seems more appropriate.

[wooorm]

I’m open to it. But I can then still see #136 (reply in thread) happening in the future, where it’s split out again (which we could discuss then)

[remcohaszing]

This is really minor. If @wooorm prefers to keep both the Plugin and Attacher type we can just keep them and close this discussion.

[wooorm]

Given that we’re all a bit 🤷‍♂️ on whether or not to do this and unified is already seeing quite a few (good) breaking changes at the moment that are causing confusion and updating troubles, even though it’s probably a good idea, I think it’s best to not change it to not rock the boat further.
Okay to table it and keep it as is?

[ChristianMurphy]

Attacher has been deprecated in 10

unified/index.d.ts

Lines 394 to 399 in 4919517

	/**
	* @deprecated
	* Please use `Plugin`.
	*/
	export type Attacher<PluginParameters extends any[] = any[]> =
	Plugin<PluginParameters>